Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-12 Thread Zhang, Qi Z
on, Benjamin H ; Vangati, Narender > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare > > Hi, > > On Thu, Jul 12, 2018 at 10:24:44AM +0100, Burakov, Anatoly wrote: > > On 12-Jul-18 2:14 AM, Qi Zhang wrote: > > >

Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-12 Thread Zhang, Qi Z
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, July 12, 2018 5:25 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > ; sta...@dpdk.org > Subject: Re: [PAT

Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-12 Thread Gaƫtan Rivet
Hi, On Thu, Jul 12, 2018 at 10:24:44AM +0100, Burakov, Anatoly wrote: > On 12-Jul-18 2:14 AM, Qi Zhang wrote: > > When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) > > is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr > > is valid. So compare the 8th b

Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-12 Thread Burakov, Anatoly
On 12-Jul-18 2:14 AM, Qi Zhang wrote: When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr is valid. So compare the 8th byte will cause the unexpected result, which happens when repeatedly attach/detach a

[dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-11 Thread Qi Zhang
When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr is valid. So compare the 8th byte will cause the unexpected result, which happens when repeatedly attach/detach a device. Fixes: c752998b5e2e ("pci: int