Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP packet

2018-01-16 Thread Wang, Xiao W
..@fridaylinux.org; tho...@monjalon.net; Bie, Tiwei > > ; dev@dpdk.org; step...@networkplumber.org; > > maxime.coque...@redhat.com > > Subject: Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP > > packet > > > > Hi Xiao, > > > > On Tue, Ja

Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP packet

2018-01-16 Thread Wang, Xiao W
e.coque...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP > packet > > Hi Xiao, > > On Tue, Jan 16, 2018 at 09:43:43AM +, Wang, Xiao W wrote: > > Hi Olivier, > > > You can also use rte_pktmbuf_append() to check for the tailr

Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP packet

2018-01-16 Thread Olivier Matz
Hi Xiao, On Tue, Jan 16, 2018 at 09:43:43AM +, Wang, Xiao W wrote: > Hi Olivier, > > You can also use rte_pktmbuf_append() to check for the tailroom and > > update data_len/pkt_len: > > > > m = rte_pktmbuf_alloc(); > > if (m == NULL) > > return NULL; > > eth_hdr = rte_

Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP packet

2018-01-16 Thread Wang, Xiao W
e.coque...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP > packet > > Hi Xiao, > > Please find few comments below. > > On Wed, Jan 10, 2018 at 09:23:54AM +0800, Xiao Wang wrote: > > Suggested-by: Maxime Coquelin > > S

Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP packet

2018-01-16 Thread Olivier Matz
Hi Xiao, Please find few comments below. On Wed, Jan 10, 2018 at 09:23:54AM +0800, Xiao Wang wrote: > Suggested-by: Maxime Coquelin > Signed-off-by: Xiao Wang > Reviewed-by: Maxime Coquelin > --- > lib/librte_net/Makefile| 1 + > lib/librte_net/rte_arp.c | 42 > +++

Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP packet

2018-01-10 Thread Thomas Monjalon
10/01/2018 14:06, Yuanhan Liu: > Thomas, look good to you? The format looks good, yes. Cc Olivier, the maintainer.

Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP packet

2018-01-10 Thread Yuanhan Liu
Thomas, look good to you? --yliu On Wed, Jan 10, 2018 at 09:23:54AM +0800, Xiao Wang wrote: > Suggested-by: Maxime Coquelin > Signed-off-by: Xiao Wang > Reviewed-by: Maxime Coquelin > --- > lib/librte_net/Makefile| 1 + > lib/librte_net/rte_arp.c | 42 > +++

[dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP packet

2018-01-09 Thread Xiao Wang
Suggested-by: Maxime Coquelin Signed-off-by: Xiao Wang Reviewed-by: Maxime Coquelin --- lib/librte_net/Makefile| 1 + lib/librte_net/rte_arp.c | 42 ++ lib/librte_net/rte_arp.h | 17 +++ lib/librte_net/rte_net_vers