Re: [dpdk-dev] [PATCH v10 11/20] unci: add netlink exec

2017-07-06 Thread Stephen Hemminger
On Thu, 6 Jul 2017 11:45:48 +0100 Ferruh Yigit wrote: > > > Blocking for completion with mutex held? > > Sleeping with mutex held is not allowed in Linux. > > > > You will see this if you run with lockdep and all the other kernel debug > > config options. > > Thank you for the review, > >

Re: [dpdk-dev] [PATCH v10 11/20] unci: add netlink exec

2017-07-06 Thread Ferruh Yigit
On 7/5/2017 8:07 PM, Stephen Hemminger wrote: > On Tue, 4 Jul 2017 17:13:28 +0100 > Ferruh Yigit wrote: > >> +int unci_nl_exec(u32 cmd, struct net_device *dev, void *in_data, >> +size_t in_data_len, void *out_data, size_t out_data_len) >> +{ >> +struct unci_dev *unci = netdev_pri

Re: [dpdk-dev] [PATCH v10 11/20] unci: add netlink exec

2017-07-05 Thread Stephen Hemminger
On Tue, 4 Jul 2017 17:13:28 +0100 Ferruh Yigit wrote: > + > + if (nl_msg->err == 0 && recv_len != expected_len) > + pr_info("Expected and received len not match " > + "%zu - %zu\n", recv_len, expected_len); > +

Re: [dpdk-dev] [PATCH v10 11/20] unci: add netlink exec

2017-07-05 Thread Stephen Hemminger
On Tue, 4 Jul 2017 17:13:28 +0100 Ferruh Yigit wrote: > +int unci_nl_exec(u32 cmd, struct net_device *dev, void *in_data, > + size_t in_data_len, void *out_data, size_t out_data_len) > +{ > + struct unci_dev *unci = netdev_priv(dev); > + int err = -EINVAL; > + int ret; >

[dpdk-dev] [PATCH v10 11/20] unci: add netlink exec

2017-07-04 Thread Ferruh Yigit
Add netlink exec function, which sends a message to userspace and waits and receives the response from userspace. Signed-off-by: Ferruh Yigit --- .../linuxapp/eal/include/exec-env/unci.h | 6 + lib/librte_eal/linuxapp/unci/unci_dev.h| 4 + lib/librte_eal/linuxapp/unci/u