Re: [dpdk-dev] [PATCH v10 08/27] devargs: add function to parse device layers

2018-07-11 Thread Thomas Monjalon
11/07/2018 10:41, Gaëtan Rivet: > > > + struct rte_bus *bus; /**< bus handle. */ > > > + struct rte_class *cls; /**< class handle. */ > > > > "class" is more readable than "cls" > > > > I was thinking that maybe this could be a problem when trying to build > with C++. The EAL headers in DPDK are

Re: [dpdk-dev] [PATCH v10 08/27] devargs: add function to parse device layers

2018-07-11 Thread Gaëtan Rivet
Hi Thomas, On Wed, Jul 11, 2018 at 10:19:07AM +0200, Thomas Monjalon wrote: > 05/07/2018 13:48, Gaetan Rivet: > > +/** > > + * @internal > > + * Parse a device string and store its information in an > > + * rte_devargs structure. > > Please, explain what is a layer. > > > + * > > + * Note: if th

Re: [dpdk-dev] [PATCH v10 08/27] devargs: add function to parse device layers

2018-07-11 Thread Thomas Monjalon
05/07/2018 13:48, Gaetan Rivet: > +/** > + * @internal > + * Parse a device string and store its information in an > + * rte_devargs structure. Please, explain what is a layer. > + * > + * Note: if the "data" field of da points to devstr, Better to use "devargs" as variable name, instead of "da"

[dpdk-dev] [PATCH v10 08/27] devargs: add function to parse device layers

2018-07-05 Thread Gaetan Rivet
This function is private to the EAL. It is used to parse each layers in a device description string, and store the result in an rte_devargs structure. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 144 lib/librte_eal/common/eal_private.h