Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-26 Thread Ye Xiaolong
On 03/26, Luca Boccassi wrote: >On Tue, 2019-03-26 at 10:18 +0800, Ye Xiaolong wrote: >> On 03/25, Luca Boccassi wrote: >> > On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote: >> > > On 03/24, Luca Boccassi wrote: >> > > > On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: >> > > > > On 03/02

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-26 Thread Luca Boccassi
On Tue, 2019-03-26 at 10:18 +0800, Ye Xiaolong wrote: > On 03/25, Luca Boccassi wrote: > > On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote: > > > On 03/24, Luca Boccassi wrote: > > > > On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: > > > > > On 03/02, Ye Xiaolong wrote: > > > > > > > >

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-25 Thread Ye Xiaolong
On 03/25, Luca Boccassi wrote: >On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote: >> On 03/24, Luca Boccassi wrote: >> > On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: >> > > On 03/02, Ye Xiaolong wrote: >> > > > > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += >> > > > > > -lrte_pmd_

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-25 Thread Ye Xiaolong
On 03/25, Luca Boccassi wrote: >On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote: >> On 03/24, Luca Boccassi wrote: >> > On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: >> > > On 03/02, Ye Xiaolong wrote: >> > > > > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += >> > > > > > -lrte_pmd_

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-25 Thread Luca Boccassi
On Mon, 2019-03-25 at 10:45 +0800, Ye Xiaolong wrote: > On 03/24, Luca Boccassi wrote: > > On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: > > > On 03/02, Ye Xiaolong wrote: > > > > > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += > > > > > > -lrte_pmd_af_packet > > > > > > +_LDLIBS-$(CONF

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-24 Thread Ye Xiaolong
On 03/24, Luca Boccassi wrote: >On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: >> On 03/02, Ye Xiaolong wrote: >> > > >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET)  += >> > > > -lrte_pmd_af_packet >> > > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += >> > > > -lrte_pmd_af_xdp >> > > > -le

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-24 Thread Luca Boccassi
On Sun, 2019-03-17 at 11:34 +0800, Ye Xiaolong wrote: > On 03/02, Ye Xiaolong wrote: > > > >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET)  += > > > > -lrte_pmd_af_packet > > > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += > > > > -lrte_pmd_af_xdp > > > > -lelf -lbpf > > > > > > Are symbols from

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-16 Thread Ye Xiaolong
On 03/12, Ye Xiaolong wrote: >>I can see in makefile, libelf is also linked, is it a dependency? > >libelf is a leftover of RFC, will delete it in next version. Correction, libbpf depends on libelf, so I still need to keep it. Thanks, Xiaolong

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-16 Thread Ye Xiaolong
On 03/02, Ye Xiaolong wrote: >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += -lrte_pmd_af_packet >>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_XDP) += -lrte_pmd_af_xdp >>> -lelf -lbpf >> >>Are symbols from libelf being used by the PMD? > >Hmm, it is a leftover of RFC, libelf is no longer needed i

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-13 Thread Ye Xiaolong
On 03/13, Ferruh Yigit wrote: > >>> <...> >>> +Prerequisites +- + +This is a Linux-specific PMD, thus the following prerequisites apply: + +* A Linux Kernel with XDP sockets configuration enabled; >>> >>> Can you please give more details of what exact vani

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-13 Thread Ferruh Yigit
>> <...> >> >>> +Prerequisites >>> +- >>> + >>> +This is a Linux-specific PMD, thus the following prerequisites apply: >>> + >>> +* A Linux Kernel with XDP sockets configuration enabled; >> >> Can you please give more details of what exact vanilla kernel version? > > Do you mean I s

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-12 Thread Ye Xiaolong
Hi, Ferruh Thanks for your review. On 03/11, Ferruh Yigit wrote: >On 3/1/2019 8:09 AM, Xiaolong Ye wrote: >> Add a new PMD driver for AF_XDP which is a proposed faster version of >> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] >> [2]. >> >> This is the vanilla versio

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-11 Thread Ferruh Yigit
On 3/1/2019 8:09 AM, Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer registered as > the umem. > > [1] htt

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-06 Thread Ye Xiaolong
Hi, David Thanks for your review. On 03/05, David Marchand wrote: >On Fri, Mar 1, 2019 at 9:13 AM Xiaolong Ye wrote: > >> diff --git a/doc/guides/rel_notes/release_18_11.rst >> b/doc/guides/rel_notes/release_18_11.rst >> index 65bab557d..e0918441a 100644 >> --- a/doc/guides/rel_notes/release_18_

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-05 Thread David Marchand
On Fri, Mar 1, 2019 at 9:13 AM Xiaolong Ye wrote: > diff --git a/doc/guides/rel_notes/release_18_11.rst > b/doc/guides/rel_notes/release_18_11.rst > index 65bab557d..e0918441a 100644 > --- a/doc/guides/rel_notes/release_18_11.rst > +++ b/doc/guides/rel_notes/release_18_11.rst > @@ -229,6 +229,13

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-02 Thread Ye Xiaolong
Hi, Luca Thanks for your review. On 03/01, Luca Boccassi wrote: >On Fri, 2019-03-01 at 16:09 +0800, Xiaolong Ye wrote: >> Add a new PMD driver for AF_XDP which is a proposed faster version of >> AF_PACKET interface in Linux. More info about AF_XDP, please refer to >> [1] >> [2]. >> >> This is th

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-02 Thread Ye Xiaolong
Hi, On 03/01, Stephen Hemminger wrote: >On Fri, 1 Mar 2019 16:09:42 +0800 >Xiaolong Ye wrote: > >> +if (umem->buffer) >> +free(umem->buffer); > >Minor nit: you don't need to check for NULL free() already handles this. Thanks for the suggestion, will change accordingly.

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-02 Thread Ye Xiaolong
Hi, On 03/01, Stephen Hemminger wrote: >On Fri, 1 Mar 2019 16:09:42 +0800 >Xiaolong Ye wrote: > >> + >> +static int >> +rte_pmd_af_xdp_probe(struct rte_vdev_device *dev) >> +{ >> +struct rte_kvargs *kvlist; >> +char *if_name = NULL; >> +int queue_idx = ETH_AF_XDP_DFLT_QUEUE_IDX; >> +

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-01 Thread Stephen Hemminger
On Fri, 1 Mar 2019 16:09:42 +0800 Xiaolong Ye wrote: > + > +static int > +rte_pmd_af_xdp_probe(struct rte_vdev_device *dev) > +{ > + struct rte_kvargs *kvlist; > + char *if_name = NULL; > + int queue_idx = ETH_AF_XDP_DFLT_QUEUE_IDX; > + struct rte_eth_dev *eth_dev; > + const

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-01 Thread Stephen Hemminger
On Fri, 1 Mar 2019 16:09:42 +0800 Xiaolong Ye wrote: > + if (umem->buffer) > + free(umem->buffer); Minor nit: you don't need to check for NULL free() already handles this.

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-01 Thread Luca Boccassi
On Fri, 2019-03-01 at 16:09 +0800, Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to > [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer > registered as > the

[dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-01 Thread Xiaolong Ye
Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.org/2018/schedule/event/af_xdp/ [2] https://