Re: [dpdk-dev] [PATCH v1 1/4] test/power: fix check for cpu frequency

2021-05-11 Thread Pattan, Reshma
> -Original Message- > From: Hunt, David > > [Reshma]: Do we need to return -1 here and in other failure scenarios > > below. > > > Hi Reshma, > > We might do, but that's not something I had intended to address in this patch > set. > > We should look at this in a future patch, OK?

Re: [dpdk-dev] [PATCH v1 1/4] test/power: fix check for cpu frequency

2021-05-11 Thread David Hunt
On 29/4/2021 11:34 AM, Pattan, Reshma wrote: -Original Message- From: dev On Behalf Of David Hunt +TEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) { return 0; [Reshma]: Do we need to return -1 here and in other failure scenarios below. Hi Reshma, We might do, but that's not s

Re: [dpdk-dev] [PATCH v1 1/4] test/power: fix check for cpu frequency

2021-04-29 Thread Pattan, Reshma
> -Original Message- > From: dev On Behalf Of David Hunt > + TEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) { > return 0; [Reshma]: Do we need to return -1 here and in other failure scenarios below. > } > f = fopen(fullpath, "r"); > if (f

[dpdk-dev] [PATCH v1 1/4] test/power: fix check for cpu frequency

2021-04-22 Thread David Hunt
Different drivers present the current cpu core frequency in different sysfs iles. Some present it in cpuinfo_cur_freq, some in scaling_cur_freq, and some actually present it in both. This patch attempts to open one, if that fails, tries the other. Fixes: d550a8cc31f3 ("app/test: enhance power man