Re: [dpdk-dev] [PATCH v1 1/2] malloc: support malloc and free tracking log

2020-04-07 Thread Xueming(Steven) Li
Thanks for your suggestion, will include them in next version. > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, April 8, 2020 1:12 PM > To: Xueming(Steven) Li > Cc: Anatoly Burakov ; Ferruh Yigit > ; dev@dpdk.org; Asaf Penso > Subject: Re: [dp

Re: [dpdk-dev] [PATCH v1 1/2] malloc: support malloc and free tracking log

2020-04-07 Thread Stephen Hemminger
On Wed, 8 Apr 2020 04:04:53 + Xueming Li wrote: > * Dump contents of all malloc heaps to a file. > diff --git a/lib/librte_eal/rte_eal_version.map > b/lib/librte_eal/rte_eal_version.map > index f9ede5b..25c4b13 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_ea

Re: [dpdk-dev] [PATCH v1 1/2] malloc: support malloc and free tracking log

2020-04-07 Thread Stephen Hemminger
On Wed, 8 Apr 2020 04:04:53 + Xueming Li wrote: > int n_alloc_free = 0; > + int n_alloc = 0; > + int n_free_alloc = 0; > + int n_free = 0; > + size_t alloc_leak = 0; All statistics should be unsigned, size_t or uint64_t to avoid any wraparound issues.

[dpdk-dev] [PATCH v1 1/2] malloc: support malloc and free tracking log

2020-04-07 Thread Xueming Li
This patch introduces new feature to track rte_malloc leakage by logging malloc and free. Signed-off-by: Xueming Li --- lib/librte_eal/common/eal_memcfg.h | 26 lib/librte_eal/common/malloc_elem.h | 6 +- lib/librte_eal/common/rte_malloc.c | 259 +++- li