Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-03-01 Thread Bruce Richardson
On Wed, Mar 01, 2017 at 04:49:56PM +0530, Jerin Jacob wrote: > On Wed, Mar 01, 2017 at 12:06:33PM +0100, Olivier Matz wrote: > > On Wed, 1 Mar 2017 10:42:58 +, Bruce Richardson > > wrote: > > > On Wed, Mar 01, 2017 at 11:17:53AM +0100, Olivier Matz wrote: > > > > On Wed, 1 Mar 2017 09:47:03 +

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-03-01 Thread Jerin Jacob
On Wed, Mar 01, 2017 at 12:06:33PM +0100, Olivier Matz wrote: > On Wed, 1 Mar 2017 10:42:58 +, Bruce Richardson > wrote: > > On Wed, Mar 01, 2017 at 11:17:53AM +0100, Olivier Matz wrote: > > > On Wed, 1 Mar 2017 09:47:03 +, Bruce Richardson > > > wrote: > > > > So given that there is n

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-03-01 Thread Olivier Matz
On Wed, 1 Mar 2017 10:42:58 +, Bruce Richardson wrote: > On Wed, Mar 01, 2017 at 11:17:53AM +0100, Olivier Matz wrote: > > On Wed, 1 Mar 2017 09:47:03 +, Bruce Richardson > > wrote: > > > So given that there is not much difference here, is the MIN_SIZE i.e. > > > forced 64B, your prefe

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-03-01 Thread Bruce Richardson
On Wed, Mar 01, 2017 at 11:17:53AM +0100, Olivier Matz wrote: > Hi Bruce, > > On Wed, 1 Mar 2017 09:47:03 +, Bruce Richardson > wrote: > > On Tue, Feb 28, 2017 at 11:24:25PM +0530, Jerin Jacob wrote: > > > On Tue, Feb 28, 2017 at 01:52:26PM +, Bruce Richardson wrote: > > > > On Tue, Feb

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-03-01 Thread Olivier Matz
Hi Bruce, On Wed, 1 Mar 2017 09:47:03 +, Bruce Richardson wrote: > On Tue, Feb 28, 2017 at 11:24:25PM +0530, Jerin Jacob wrote: > > On Tue, Feb 28, 2017 at 01:52:26PM +, Bruce Richardson wrote: > > > On Tue, Feb 28, 2017 at 05:38:34PM +0530, Jerin Jacob wrote: > > > > On Tue, Feb 28,

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-03-01 Thread Bruce Richardson
On Tue, Feb 28, 2017 at 11:24:25PM +0530, Jerin Jacob wrote: > On Tue, Feb 28, 2017 at 01:52:26PM +, Bruce Richardson wrote: > > On Tue, Feb 28, 2017 at 05:38:34PM +0530, Jerin Jacob wrote: > > > On Tue, Feb 28, 2017 at 11:57:03AM +, Bruce Richardson wrote: > > > > On Tue, Feb 28, 2017 at 0

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-02-28 Thread Jerin Jacob
On Tue, Feb 28, 2017 at 01:52:26PM +, Bruce Richardson wrote: > On Tue, Feb 28, 2017 at 05:38:34PM +0530, Jerin Jacob wrote: > > On Tue, Feb 28, 2017 at 11:57:03AM +, Bruce Richardson wrote: > > > On Tue, Feb 28, 2017 at 05:05:13PM +0530, Jerin Jacob wrote: > > > > On Thu, Feb 23, 2017 at 0

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-02-28 Thread Bruce Richardson
On Tue, Feb 28, 2017 at 05:38:34PM +0530, Jerin Jacob wrote: > On Tue, Feb 28, 2017 at 11:57:03AM +, Bruce Richardson wrote: > > On Tue, Feb 28, 2017 at 05:05:13PM +0530, Jerin Jacob wrote: > > > On Thu, Feb 23, 2017 at 05:23:54PM +, Bruce Richardson wrote: > > > > Users compiling DPDK shou

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-02-28 Thread Jerin Jacob
On Tue, Feb 28, 2017 at 11:57:03AM +, Bruce Richardson wrote: > On Tue, Feb 28, 2017 at 05:05:13PM +0530, Jerin Jacob wrote: > > On Thu, Feb 23, 2017 at 05:23:54PM +, Bruce Richardson wrote: > > > Users compiling DPDK should not need to know or care about the arrangement > > > of cachelines

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-02-28 Thread Bruce Richardson
On Tue, Feb 28, 2017 at 05:05:13PM +0530, Jerin Jacob wrote: > On Thu, Feb 23, 2017 at 05:23:54PM +, Bruce Richardson wrote: > > Users compiling DPDK should not need to know or care about the arrangement > > of cachelines in the rte_ring structure. Therefore just remove the build > > option and

Re: [dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-02-28 Thread Jerin Jacob
On Thu, Feb 23, 2017 at 05:23:54PM +, Bruce Richardson wrote: > Users compiling DPDK should not need to know or care about the arrangement > of cachelines in the rte_ring structure. Therefore just remove the build > option and set the structures to be always split. For improved > performance us

[dpdk-dev] [PATCH v1 01/14] ring: remove split cacheline build setting

2017-02-23 Thread Bruce Richardson
Users compiling DPDK should not need to know or care about the arrangement of cachelines in the rte_ring structure. Therefore just remove the build option and set the structures to be always split. For improved performance use 128B rather than 64B alignment since it stops the producer and consumer