Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-05-05 Thread Tyler Retzlaff
On Wed, May 05, 2021 at 12:37:50AM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > your subject line indicates the use of C11 which is a standard [1]. > > > > > > > > the patch itself uses gcc atomics builtins which are not part of C11 > > > > standard so the subject line is incorrect a

Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-05-04 Thread Honnappa Nagarahalli
> > > > > > your subject line indicates the use of C11 which is a standard [1]. > > > > > > the patch itself uses gcc atomics builtins which are not part of C11 > > > standard so the subject line is incorrect and misleading. > > Ok, understood. How about the following? > > "use gcc's C11 atomic

Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-04-30 Thread Tyler Retzlaff
On Thu, Apr 29, 2021 at 09:10:04PM +, Honnappa Nagarahalli wrote: > > > > > > your subject line indicates the use of C11 which is a standard [1]. > > > > the patch itself uses gcc atomics builtins which are not part of C11 > > standard so > > the subject line is incorrect and misleading. >

Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-04-29 Thread Stephen Hemminger
On Thu, 29 Apr 2021 21:10:04 + Honnappa Nagarahalli wrote: > > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic > > > > builtins for lcores sync > > > > > > > > On Wed, Apr 21, 2021 at 02:

Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-04-29 Thread Honnappa Nagarahalli
> > > > > Subject: Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic > > > builtins for lcores sync > > > > > > On Wed, Apr 21, 2021 at 02:17:33AM -0500, Joyce Kong wrote: > > > > Convert rte_atomic usages to C11 atomic bu

Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-04-29 Thread Tyler Retzlaff
On Thu, Apr 29, 2021 at 07:17:06PM +, Honnappa Nagarahalli wrote: > > > > Subject: Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins > > for lcores sync > > > > On Wed, Apr 21, 2021 at 02:17:33AM -0500, Joyce Kong wrote: > > >

Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-04-29 Thread Honnappa Nagarahalli
> Subject: Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins > for lcores sync > > On Wed, Apr 21, 2021 at 02:17:33AM -0500, Joyce Kong wrote: > > Convert rte_atomic usages to C11 atomic builtins for lcores sync in > > ticketlock testcases. > > g

Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-04-29 Thread Tyler Retzlaff
On Wed, Apr 21, 2021 at 02:17:33AM -0500, Joyce Kong wrote: > Convert rte_atomic usages to C11 atomic builtins for lcores sync > in ticketlock testcases. gcc atomic builtins aren't 'C11' > > Signed-off-by: Joyce Kong > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > --- the c

[dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-04-21 Thread Joyce Kong
Convert rte_atomic usages to C11 atomic builtins for lcores sync in ticketlock testcases. Signed-off-by: Joyce Kong Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- app/test/test_ticketlock.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app/test/t