Re: [dpdk-dev] [PATCH v1] net/mlx4: fix RSS actions with no parameters

2018-02-26 Thread Adrien Mazarguil
On Sat, Feb 24, 2018 at 11:18:54PM +, Ophir Munk wrote: > Hi, > Please see below > > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Friday, February 23, 2018 6:53 PM > > To: Ophir Munk > > Cc: dev@dpdk.org; Thomas Monjalon ; Olga Shern >

Re: [dpdk-dev] [PATCH v1] net/mlx4: fix RSS actions with no parameters

2018-02-24 Thread Ophir Munk
Hi, Please see below > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Friday, February 23, 2018 6:53 PM > To: Ophir Munk > Cc: dev@dpdk.org; Thomas Monjalon ; Olga Shern > ; sta...@dpdk.org > Subject: Re: [PATCH v1] net/mlx4: fix RSS actions with n

Re: [dpdk-dev] [PATCH v1] net/mlx4: fix RSS actions with no parameters

2018-02-23 Thread Adrien Mazarguil
On Wed, Feb 21, 2018 at 01:38:38PM +, Ophir Munk wrote: > When creating an RSS flow with missing actions parameters, for example: > flow create 0 ingress pattern / end actions rss / end > > testpmd aborts with segmentation fault. > In the corrupted code mlx4_flow_prepare() accesses RSS actio

[dpdk-dev] [PATCH v1] net/mlx4: fix RSS actions with no parameters

2018-02-21 Thread Ophir Munk
When creating an RSS flow with missing actions parameters, for example: flow create 0 ingress pattern / end actions rss / end testpmd aborts with segmentation fault. In the corrupted code mlx4_flow_prepare() accesses RSS action->conf pointer without verifying its validity. In case of missing RSS