Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-16 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > > > > > > Add the logic to determine how many DD bits have been set > > > > > > > for contiguous packets, for removing the SMP barrier while reading > descs. > > > > > > > > > > > > I didn't understand this. > > > > > > The current logic already guarantee the read out

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-16 Thread Bruce Richardson
On Wed, Jun 16, 2021 at 01:29:24PM +, Zhang, Qi Z wrote: > Hi > > > -Original Message- > > From: Honnappa Nagarahalli > > Sent: Tuesday, June 8, 2021 5:36 AM > > To: Zhang, Qi Z ; Joyce Kong ; > > Xing, Beilei ; Ruifeng Wang > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > > ; nd >

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-16 Thread Zhang, Qi Z
Hi > -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, June 8, 2021 5:36 AM > To: Zhang, Qi Z ; Joyce Kong ; > Xing, Beilei ; Ruifeng Wang > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; nd > Subject: RE: [PATCH v1] net/i40e: remove the SMP barrier in HW scanning > func

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-14 Thread Joyce Kong
> > > > > Add the logic to determine how many DD bits have been set for > > > > > contiguous packets, for removing the SMP barrier while reading descs. > > > > > > > > I didn't understand this. > > > > The current logic already guarantee the read out DD bits are from > > > > continue packets, as

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-07 Thread Honnappa Nagarahalli
> > > > > > > > > > Add the logic to determine how many DD bits have been set for > > > > contiguous packets, for removing the SMP barrier while reading descs. > > > > > > I didn't understand this. > > > The current logic already guarantee the read out DD bits are from > > > continue packets, as

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-07 Thread Zhang, Qi Z
> -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, June 7, 2021 2:33 AM > To: Zhang, Qi Z ; Joyce Kong ; > Xing, Beilei ; Ruifeng Wang > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; nd > Subject: RE: [PATCH v1] net/i40e: remove the SMP barrier in HW scanning > func >

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-06 Thread Honnappa Nagarahalli
> > > > Add the logic to determine how many DD bits have been set for > > contiguous packets, for removing the SMP barrier while reading descs. > > I didn't understand this. > The current logic already guarantee the read out DD bits are from continue > packets, as it read Rx descriptor in a reve

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-06 Thread Zhang, Qi Z
> -Original Message- > From: Joyce Kong > Sent: Friday, June 4, 2021 3:34 PM > To: Xing, Beilei ; Zhang, Qi Z ; > ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com > Cc: dev@dpdk.org; n...@arm.com > Subject: [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func > > Add the l

Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-04 Thread Honnappa Nagarahalli
> > Add the logic to determine how many DD bits have been set for contiguous > packets, for removing the SMP barrier while reading descs. Are there any performance numbers with this change? > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > --- > drivers/net/i40e/i40e_rxtx.c | 13 ++

[dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func

2021-06-04 Thread Joyce Kong
Add the logic to determine how many DD bits have been set for contiguous packets, for removing the SMP barrier while reading descs. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- drivers/net/i40e/i40e_rxtx.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --gi