Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-24 Thread Hu, Jiayu
Hi Ophir, > -Original Message- > From: Ophir Munk [mailto:ophi...@mellanox.com] > Sent: Tuesday, April 24, 2018 9:53 PM > To: Hu, Jiayu ; Ananyev, Konstantin > ; dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > ; Pascal Mazon ; > sta...@dpdk.org > Subject: RE: [PATCH v1] gso: fix marking

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-24 Thread Ananyev, Konstantin
> -Original Message- > From: Ophir Munk [mailto:ophi...@mellanox.com] > Sent: Tuesday, April 24, 2018 2:42 PM > To: Ananyev, Konstantin ; Hu, Jiayu > ; dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern ; > Pascal Mazon ; > sta...@dpdk.org > Subject: RE: [PATCH v1] gso: fix marking TCP che

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-24 Thread Ophir Munk
Hi Jiayu, > -Original Message- > From: Hu, Jiayu [mailto:jiayu...@intel.com] > Sent: Tuesday, April 24, 2018 3:56 PM > To: Ananyev, Konstantin ; Ophir Munk > ; dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > ; Pascal Mazon ; > sta...@dpdk.org > Subject: RE: [PATCH v1] gso: fix marking TC

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-24 Thread Ophir Munk
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Tuesday, April 24, 2018 3:31 PM > To: Ophir Munk ; Hu, Jiayu ; > dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > ; Pascal Mazon ; > sta...@dpdk.org > Subject: RE: [PATCH v1] gso:

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-24 Thread Hu, Jiayu
Hi Konstantin and Ophir, > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, April 24, 2018 8:31 PM > To: Ophir Munk ; Hu, Jiayu ; > dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > ; Pascal Mazon ; > sta...@dpdk.org > Subject: RE: [PATCH v1] gso: fix marking TCP checksum fl

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-24 Thread Ananyev, Konstantin
Hi Ophir, > > Hi Konstantin, > Please see inline > > > -Original Message- > > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > > Sent: Tuesday, April 24, 2018 1:56 PM > > To: Ophir Munk ; Hu, Jiayu ; > > dev@dpdk.org > > Cc: Thomas Monjalon ; Olga Shern > > ; Pascal Maz

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-24 Thread Ophir Munk
Hi Konstantin, Please see inline > -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Tuesday, April 24, 2018 1:56 PM > To: Ophir Munk ; Hu, Jiayu ; > dev@dpdk.org > Cc: Thomas Monjalon ; Olga Shern > ; Pascal Mazon ; > sta...@dpdk.org > Subject: R

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-24 Thread Ananyev, Konstantin
> -Original Message- > From: Ophir Munk [mailto:ophi...@mellanox.com] > Sent: Tuesday, April 24, 2018 10:44 AM > To: Hu, Jiayu ; dev@dpdk.org; Ananyev, Konstantin > > Cc: Thomas Monjalon ; Olga Shern ; > Pascal Mazon ; > sta...@dpdk.org > Subject: RE: [PATCH v1] gso: fix marking TCP ch

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-24 Thread Ophir Munk
Hi Jiayu, Please find comments inline > -Original Message- > From: Hu, Jiayu [mailto:jiayu...@intel.com] > Sent: Monday, April 23, 2018 7:14 AM > To: Ophir Munk ; dev@dpdk.org; Ananyev, > Konstantin > Cc: Thomas Monjalon ; Olga Shern > ; Pascal Mazon ; > sta...@dpdk.org > Subject: RE: [PA

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-22 Thread Hu, Jiayu
Hi Ophir, In the GSO design, the GSO library doesn't care about checksums, which means it doesn't check if input packets have correct checksums, and it doesn't do any checksum related work for the output GSO segments. It depends on the callers to use HW or SW checksum calculation for output packet

Re: [dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-22 Thread Ophir Munk
Hi Ferruh, Thomas, Please note that this patch should be merged before the net/tap TSO patches: https://dpdk.org/dev/patchwork/patch/38666/ https://dpdk.org/dev/patchwork/patch/38667/ Regards, Ophir > -Original Message- > From: Ophir Munk > Sent: Sunday, April 22, 2018 5:21 PM > To: dev@

[dpdk-dev] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments

2018-04-22 Thread Ophir Munk
Large TCP packets which are marked with PKT_TX_TCP_SEG flag are segmented and the flag is cleared in the resulting segments, however, the segments checksum is not updated. It is therefore required to set the PKT_TX_TCP_CKSUM flag in each TCP segment in order to mark for the sending driver the need