Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun

2019-04-23 Thread Kevin Traynor
On 23/04/2019 11:31, Hunt, David wrote: > Hi Kevin, > > On 23/4/2019 11:26 AM, Kevin Traynor wrote: >> On 18/04/2019 16:14, Pattan, Reshma wrote: Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host") Coverity issue: 337660 >>> Candidate for sta...@dpdk.org? >> There is n

Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun

2019-04-23 Thread Hunt, David
Hi Kevin, On 23/4/2019 11:26 AM, Kevin Traynor wrote: On 18/04/2019 16:14, Pattan, Reshma wrote: Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host") Coverity issue: 337660 Candidate for sta...@dpdk.org? There is no reply to this comment - re-asking as I will probably have t

Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun

2019-04-23 Thread Kevin Traynor
On 18/04/2019 16:14, Pattan, Reshma wrote: >> Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host") >> Coverity issue: 337660 > Candidate for sta...@dpdk.org? There is no reply to this comment - re-asking as I will probably have the same question in a few weeks :-)

Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun

2019-04-23 Thread Hunt, David
On 23/4/2019 9:33 AM, Thomas Monjalon wrote: 23/04/2019 10:21, Hunt, David: Hi Thomas, On 22/4/2019 10:54 PM, Thomas Monjalon wrote: 10/04/2019 14:49, David Hunt: The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements, yet the code can attemtp to look at the index at POWER_MAN

Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun

2019-04-23 Thread Thomas Monjalon
23/04/2019 10:21, Hunt, David: > Hi Thomas, > > On 22/4/2019 10:54 PM, Thomas Monjalon wrote: > > 10/04/2019 14:49, David Hunt: > >> The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements, > >> yet the code can attemtp to look at the index at POWER_MANAGER_MAX_CPUS, > >> which may be

Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun

2019-04-23 Thread Hunt, David
Hi Thomas, On 22/4/2019 10:54 PM, Thomas Monjalon wrote: 10/04/2019 14:49, David Hunt: The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements, yet the code can attemtp to look at the index at POWER_MANAGER_MAX_CPUS, which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index

Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun

2019-04-22 Thread Thomas Monjalon
10/04/2019 14:49, David Hunt: > The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements, > yet the code can attemtp to look at the index at POWER_MANAGER_MAX_CPUS, > which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to > RTE_MAX_LCORE_FREQS. > > Fixes: d26c18c93260 ("e

Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun

2019-04-18 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Wednesday, April 10, 2019 1:49 PM > To: dev@dpdk.org > Cc: Hunt, David ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer > overrun

[dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun

2019-04-10 Thread David Hunt
The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements, yet the code can attemtp to look at the index at POWER_MANAGER_MAX_CPUS, which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to RTE_MAX_LCORE_FREQS. Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host")