Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 10:39:33AM +0100, David Marchand wrote: > On Thu, Nov 12, 2020 at 10:31 AM Bruce Richardson > wrote: > > > > main.c should check for RTE_RAW_IOAT before including ioat.h. > > > > And then in this header, you can remove this stub too. > > > > > > > > > > As for this one, ioa

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-12 Thread David Marchand
On Thu, Nov 12, 2020 at 10:31 AM Bruce Richardson wrote: > > > main.c should check for RTE_RAW_IOAT before including ioat.h. > > > And then in this header, you can remove this stub too. > > > > > > > As for this one, ioat.h don't have dependency on IOAT driver, it is needed > > by the example reg

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-12 Thread Bruce Richardson
On Thu, Nov 12, 2020 at 07:14:26AM +, Jiang, Cheng1 wrote: > Hi, > > > -Original Message- > > From: David Marchand > > Sent: Wednesday, November 11, 2020 10:36 PM > > To: Jiang, Cheng1 > > Cc: Maxime Coquelin ; Xia, Chenbo > > ; dev ; Fu, Patrick > > ; Yang, YvonneX ; Hu, > > Jiayu ;

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-11 Thread Jiang, Cheng1
Hi, > -Original Message- > From: David Marchand > Sent: Wednesday, November 11, 2020 10:36 PM > To: Jiang, Cheng1 > Cc: Maxime Coquelin ; Xia, Chenbo > ; dev ; Fu, Patrick > ; Yang, YvonneX ; Hu, > Jiayu ; Thomas Monjalon ; > Yigit, Ferruh > Subject: Re: [PATCH v1] examples/vhost: fix i

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-11 Thread Bruce Richardson
On Wed, Nov 11, 2020 at 03:36:25PM +0100, David Marchand wrote: > On Wed, Nov 11, 2020 at 12:29 PM Cheng Jiang wrote: > > > > Fix vhost-switch compiling issue when ioat dependency is missing. > > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file > > and update Makefile. > > Sti

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-11 Thread David Marchand
On Wed, Nov 11, 2020 at 12:29 PM Cheng Jiang wrote: > > Fix vhost-switch compiling issue when ioat dependency is missing. > Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file > and update Makefile. Still failing for me. 98b4c65506 - (HEAD) examples/vhost: fix ioat dependency iss

[dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue

2020-11-11 Thread Cheng Jiang
Fix vhost-switch compiling issue when ioat dependency is missing. Change 'RTE_x86' check into 'RTE_RAW_IOAT' check in meson build file and update Makefile. Signed-off-by: Cheng Jiang --- examples/vhost/Makefile| 5 + examples/vhost/ioat.h | 2 +- examples/vhost/meson.build | 2 +- 3