Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-26 Thread Thomas Monjalon
20/01/2021 15:25, Ray Kinsella: > Update the ignore entry for crytodev to use named fields instead of > bit positions. > > Fixes: 1c3ffb9559 > > Signed-off-by: Ray Kinsella > --- > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -15,4 +15,4 @@ > ; Ignore fields inse

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-24 Thread Dodji Seketeli
"Kinsella, Ray" writes: > On 22/01/2021 13:09, Dodji Seketeli wrote: >> Thomas Monjalon writes: >> >> [...] >> > Then I've added (quickly) a libabigail exception rule: > > [suppress_type] > name = rte_cryptodev > has_data_member_inserted_between = {0, 1023} > >

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-22 Thread Kinsella, Ray
On 22/01/2021 13:09, Dodji Seketeli wrote: > Thomas Monjalon writes: > > [...] > Then I've added (quickly) a libabigail exception rule: [suppress_type] name = rte_cryptodev has_data_member_inserted_between = {0, 1023} Now we want to improve this rule t

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-22 Thread Dodji Seketeli
Thomas Monjalon writes: [...] >> > Then I've added (quickly) a libabigail exception rule: >> > >> > [suppress_type] >> >name = rte_cryptodev >> >has_data_member_inserted_between = {0, 1023} >> > >> > Now we want to improve this rule to restrict the offsets >> > to the padding at the end

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-22 Thread Kinsella, Ray
On 21/01/2021 15:58, Thomas Monjalon wrote: > 21/01/2021 16:15, Dodji Seketeli: >> Hello Thomas and others, >> >> Thomas Monjalon writes: >> >>> Question to an expert, Dodji, >> >> Thanks for the kind words, but I am not an expert in anything, sadly. I >> am just trying to keep learning about

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-21 Thread Thomas Monjalon
21/01/2021 16:15, Dodji Seketeli: > Hello Thomas and others, > > Thomas Monjalon writes: > > > Question to an expert, Dodji, > > Thanks for the kind words, but I am not an expert in anything, sadly. I > am just trying to keep learning about these things ;-) > > > We have this structure: > > >

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-21 Thread Dodji Seketeli
Hello Thomas and others, Thomas Monjalon writes: > Question to an expert, Dodji, Thanks for the kind words, but I am not an expert in anything, sadly. I am just trying to keep learning about these things ;-) > We have this structure: > > struct rte_cryptodev { > lot of fields... >

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-20 Thread Thomas Monjalon
Question to an expert, Dodji, We have this structure: struct rte_cryptodev { lot of fields... uint8_t attached : 1; } __rte_cache_aligned; Because of the cache alignment, there is enough padding in the struct (no matter the size of the cache line) for adding two more pointers: s

[dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-20 Thread Ray Kinsella
Update the ignore entry for crytodev to use named fields instead of bit positions. Fixes: 1c3ffb9559 Signed-off-by: Ray Kinsella --- devtools/libabigail.abignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index