[dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support

2014-05-19 Thread Thomas Monjalon
Hi, I'll try so sum it up this interesting discussion about checksum API for TSO. We know at least 2 checksum methods: - the standard one - the special one for ixgbe TSO In Linux ixgbe, checksum is redone in the driver for TSO case. We want to compute checksum in the application/stack in order t

[dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support

2014-05-16 Thread Ananyev, Konstantin
TSO in the future. If #1 means moving pseudo checksum calculation out of PMD code, then my vote would be for it. Konstantin -Original Message- From: Olivier MATZ [mailto:olivier.m...@6wind.com] Sent: Friday, May 16, 2014 1:12 PM To: Ananyev, Konstantin; dev at dpdk.org Subject: Re: [dpdk-dev]

[dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support

2014-05-16 Thread Olivier MATZ
Hi Konstantin, On 05/15/2014 06:30 PM, Ananyev, Konstantin wrote: > With the current DPDK implementation the upper code would still be different > for TCP checksum (without segmentation) and TCP segmentation: > different flags in mbuf, with TSO you need to setup l4_len and mss fields > inside mb

[dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support

2014-05-15 Thread Olivier MATZ
Hi Konstantin, On 05/15/2014 05:09 PM, Ananyev, Konstantin wrote: > By design PMD not supposed to touch (or even look) into actual packet's data. I agree on the principle, we should avoid that as much as possible. > That is one of the reason why we put l2/l3/l4_len fields into the mbuf itself. >

[dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support

2014-05-15 Thread Ananyev, Konstantin
y 15, 2014 4:40 PM To: Ananyev, Konstantin; dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support Hi Konstantin, On 05/15/2014 05:09 PM, Ananyev, Konstantin wrote: > By design PMD not supposed to touch (or even look) into actual packet's data. I agree on t

[dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support

2014-05-15 Thread Ananyev, Konstantin
k.org Subject: [dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support Implement TSO (TCP segmentation offload) in ixgbe driver. To delegate the TCP segmentation to the hardware, the user has to: - set the PKT_TX_TCP_SEG flag in mbuf->ol_flags (this flag implies PKT_TX_IP_CKSUM and PKT_TX_T

[dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support

2014-05-12 Thread Thomas Monjalon
2014-05-09 16:50, Olivier Matz: > Implement TSO (TCP segmentation offload) in ixgbe driver. To delegate > the TCP segmentation to the hardware, the user has to: > > - set the PKT_TX_TCP_SEG flag in mbuf->ol_flags (this flag implies > PKT_TX_IP_CKSUM and PKT_TX_TCP_CKSUM) > - fill the mbuf->hw_of

[dpdk-dev] [PATCH RFC 11/11] ixgbe/mbuf: add TSO support

2014-05-09 Thread Olivier Matz
Implement TSO (TCP segmentation offload) in ixgbe driver. To delegate the TCP segmentation to the hardware, the user has to: - set the PKT_TX_TCP_SEG flag in mbuf->ol_flags (this flag implies PKT_TX_IP_CKSUM and PKT_TX_TCP_CKSUM) - fill the mbuf->hw_offload information: l2_len, l3_len, l4_len, m