[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-18 Thread Matthew Hall
On Fri, Oct 17, 2014 at 09:44:49AM +, Pattan, Reshma wrote: > [Reshma]: Library just takes care of packets what it has got. No waiting > mechanism is used for missing packets. > [Reshma]: This is dependent upon how frequently packets are enqueued and > dequeued from it. Packets which are in

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-17 Thread Jay Rolette
ette [mailto:rolette at infiniteio.com] > *Sent:* Thursday, October 9, 2014 8:02 PM > *To:* Pattan, Reshma > *Cc:* dev at dpdk.org > *Subject:* Re: [dpdk-dev] [PATCH RFC] librte_reorder: new reorder library > > > > Hi Reshma, > > > > A few comments and questions

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-17 Thread Pattan, Reshma
Hi Jay, Please find comments inline. Thanks, Reshma From: Jay Rolette [mailto:role...@infiniteio.com] Sent: Thursday, October 9, 2014 8:02 PM To: Pattan, Reshma Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH RFC] librte_reorder: new reorder library Hi Reshma, A few comments and questions

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-10 Thread Bruce Richardson
On Thu, Oct 09, 2014 at 10:11:35AM -0700, Matthew Hall wrote: > On Thu, Oct 09, 2014 at 10:14:21AM +0100, Bruce Richardson wrote: > > Hi Matthew, > > > > What you are doing will indeed work, and it's the way the vast majority of > > the sample apps are written. However, this will not always work

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-09 Thread Pattan, Reshma
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Thursday, October 9, 2014 12:37 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH RFC] librte_reorder: new reorder library > > On Thu, Oct 09, 2014 at

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-09 Thread Jay Rolette
Hi Reshma, A few comments and questions about your design... 1) How do you envision the reorder library to be used? Based on the description, it seems like the expectation is that packet order would be maintained at either the interface/port level or maybe at the RX queue level. Is that right or

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-09 Thread Neil Horman
On Thu, Oct 09, 2014 at 10:21:35AM -0700, Matthew Hall wrote: > On Thu, Oct 09, 2014 at 12:09:42PM -0400, Neil Horman wrote: > > From what you've said above, sequence assignment needs to occur prior to any > > order breaking event. That means you either need to do it in individual > > PMD's > > o

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-09 Thread Neil Horman
com] > > > > Sent: Wednesday, October 8, 2014 8:16 PM > > > > To: Pattan, Reshma > > > > Cc: dev at dpdk.org > > > > Subject: Re: [dpdk-dev] [PATCH RFC] librte_reorder: new reorder > > > > library > > > > > > > > On We

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-09 Thread Pattan, Reshma
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Wednesday, October 8, 2014 8:16 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH RFC] librte_reorder: new reorder library > > On Wed, Oct 08, 2014 at

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-09 Thread Matthew Hall
On Thu, Oct 09, 2014 at 12:09:42PM -0400, Neil Horman wrote: > From what you've said above, sequence assignment needs to occur prior to any > order breaking event. That means you either need to do it in individual PMD's > on RX, or in the rte_eth library if you want to make it common. On the TX

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-09 Thread Bruce Richardson
On Wed, Oct 08, 2014 at 04:07:28PM -0700, Matthew Hall wrote: > On Wed, Oct 08, 2014 at 06:55:41PM -0400, Neil Horman wrote: > > I think because there is a possibility that multiple workers may be used > > for a > > single tx queue. > > > > Neil > > OK, so, in my application packets are RX'ed t

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-09 Thread Matthew Hall
On Thu, Oct 09, 2014 at 10:14:21AM +0100, Bruce Richardson wrote: > Hi Matthew, > > What you are doing will indeed work, and it's the way the vast majority of > the sample apps are written. However, this will not always work for everyone > else, sadly. > > First off, with RSS, there are a numbe

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-09 Thread Neil Horman
m] > > > > Sent: Tuesday, October 7, 2014 12:22 PM > > > > To: Pattan, Reshma > > > > Cc: dev at dpdk.org > > > > Subject: Re: [dpdk-dev] [PATCH RFC] librte_reorder: new reorder > > > > library > > > > > > > > On T

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-08 Thread Neil Horman
On Wed, Oct 08, 2014 at 03:41:11PM -0700, Matthew Hall wrote: > On Tue, Oct 07, 2014 at 09:33:06AM +, Pattan, Reshma wrote: > > To be used along with distributor library. Next version of distributor are > > planned to distribute incoming packets to all worker cores irrespective of > > the flo

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-08 Thread Matthew Hall
On Wed, Oct 08, 2014 at 06:55:41PM -0400, Neil Horman wrote: > I think because there is a possibility that multiple workers may be used for > a > single tx queue. > > Neil OK, so, in my application packets are RX'ed to a predictable RX queue and core using RSS. Then you put them into a predic

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-08 Thread Matthew Hall
On Tue, Oct 07, 2014 at 09:33:06AM +, Pattan, Reshma wrote: > To be used along with distributor library. Next version of distributor are > planned to distribute incoming packets to all worker cores irrespective of > the flow type. In this case to ensure in order delivery of the packets at >

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-08 Thread Neil Horman
On Wed, Oct 08, 2014 at 02:11:34PM +, Pattan, Reshma wrote: > > > > -Original Message- > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Tuesday, October 7, 2014 12:22 PM > > To: Pattan, Reshma > > Cc: dev at dpdk.org &g

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-08 Thread Pattan, Reshma
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Tuesday, October 7, 2014 12:22 PM > To: Pattan, Reshma > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH RFC] librte_reorder: new reorder library > > On Tue, Oct 07, 2014 at

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-07 Thread Pattan, Reshma
Hi All, I am planning to implement packet reorder library. Details are as below, please go through them and provide the comments. Requirement: To reorder out of ordered packets that are received from different cores. Usage: To be used along with distributor library. Next versio

[dpdk-dev] [PATCH RFC] librte_reorder: new reorder library

2014-10-07 Thread Neil Horman
On Tue, Oct 07, 2014 at 09:33:06AM +, Pattan, Reshma wrote: > Hi All, > > I am planning to implement packet reorder library. Details are as below, > please go through them and provide the comments. > > Requirement: >To reorder out of ordered packets that are received from >