Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

Hi, The original issue is with legacy QEMU (e.g.QEMUv2.6, with centos7.2 as guest kernel, without set_vring_status as an indicator). For a normal boot, the last 2 messages are set_vring_kick and set_vring_call, inside the set_vring_kick handling, virtio_is_ready() will reture true (because of th

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

On 6/18/20 8:39 AM, Matan Azrad wrote: > HI Maxime > > From: Maxime Coquelin: >> On 6/17/20 1:04 PM, Matan Azrad wrote: >> > Don’t you think that only enabled queues must be fully initialized > when their status is changed from disabled to enabled? > So, you can assume that dis

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

HI Maxime From: Maxime Coquelin: > On 6/17/20 1:04 PM, Matan Azrad wrote: > > >>> Don’t you think that only enabled queues must be fully initialized > >>> when > >> their status is changed from disabled to enabled? > >>> So, you can assume that disabled queues can stay "not fully > >>> initializ

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

On 6/17/20 1:04 PM, Matan Azrad wrote: >>> Don’t you think that only enabled queues must be fully initialized when >> their status is changed from disabled to enabled? >>> So, you can assume that disabled queues can stay "not fully initialized"... >> >> That may work but might not be following

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

Hi Maxime From: Maxime Coquelin: > Hi Matan, > > On 6/14/20 8:08 AM, Matan Azrad wrote: > > Hi Maxime > > > > From: Maxime Coquelin: > >> On 6/9/20 1:09 PM, Matan Azrad wrote: > >>> Hi Maxime > >>> > >>> From: Maxime Coquelin > Hi Matan, > > On 6/8/20 11:19 AM, Matan Azrad wrote: >

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

Hi Matan, On 6/14/20 8:08 AM, Matan Azrad wrote: > Hi Maxime > > From: Maxime Coquelin: >> On 6/9/20 1:09 PM, Matan Azrad wrote: >>> Hi Maxime >>> >>> From: Maxime Coquelin Hi Matan, On 6/8/20 11:19 AM, Matan Azrad wrote: > Hi Maxime > > From: Maxime Coquelin: >> Hi

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

Hi Maxime From: Maxime Coquelin: > On 6/9/20 1:09 PM, Matan Azrad wrote: > > Hi Maxime > > > > From: Maxime Coquelin > >> Hi Matan, > >> > >> On 6/8/20 11:19 AM, Matan Azrad wrote: > >>> Hi Maxime > >>> > >>> From: Maxime Coquelin: > Hi Matan, > > On 6/7/20 12:38 PM, Matan Azrad wro

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

On 6/9/20 1:09 PM, Matan Azrad wrote: > Hi Maxime > > From: Maxime Coquelin >> Hi Matan, >> >> On 6/8/20 11:19 AM, Matan Azrad wrote: >>> Hi Maxime >>> >>> From: Maxime Coquelin: Hi Matan, On 6/7/20 12:38 PM, Matan Azrad wrote: > Hi Maxime > > Thanks for the huge work

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

On 6/9/20 1:09 PM, Matan Azrad wrote: > > Hi Maxime > > From: Maxime Coquelin >> Hi Matan, >> >> On 6/8/20 11:19 AM, Matan Azrad wrote: >>> Hi Maxime >>> >>> From: Maxime Coquelin: Hi Matan, On 6/7/20 12:38 PM, Matan Azrad wrote: > Hi Maxime > > Thanks for the huge w

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

Hi Maxime From: Maxime Coquelin > Hi Matan, > > On 6/8/20 11:19 AM, Matan Azrad wrote: > > Hi Maxime > > > > From: Maxime Coquelin: > >> Hi Matan, > >> > >> On 6/7/20 12:38 PM, Matan Azrad wrote: > >>> Hi Maxime > >>> > >>> Thanks for the huge work. > >>> Please see a suggestion inline. > >>> >

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

Hi Matan, On 6/8/20 11:19 AM, Matan Azrad wrote: > Hi Maxime > > From: Maxime Coquelin: >> Hi Matan, >> >> On 6/7/20 12:38 PM, Matan Azrad wrote: >>> Hi Maxime >>> >>> Thanks for the huge work. >>> Please see a suggestion inline. >>> >>> From: Maxime Coquelin: Sent: Thursday, May 14, 2020 11

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

Hi Maxime From: Maxime Coquelin: > Hi Matan, > > On 6/7/20 12:38 PM, Matan Azrad wrote: > > Hi Maxime > > > > Thanks for the huge work. > > Please see a suggestion inline. > > > > From: Maxime Coquelin: > >> Sent: Thursday, May 14, 2020 11:02 AM > >> To: xiaolong...@intel.com; Shahaf Shuler ; > >

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

Hi Matan, On 6/7/20 12:38 PM, Matan Azrad wrote: > Hi Maxime > > Thanks for the huge work. > Please see a suggestion inline. > > From: Maxime Coquelin: >> Sent: Thursday, May 14, 2020 11:02 AM >> To: xiaolong...@intel.com; Shahaf Shuler ; Matan >> Azrad ; amore...@redhat.com; >> xiao.w.w...@inte

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

Hi Maxime Thanks for the huge work. Please see a suggestion inline. From: Maxime Coquelin: > Sent: Thursday, May 14, 2020 11:02 AM > To: xiaolong...@intel.com; Shahaf Shuler ; Matan > Azrad ; amore...@redhat.com; > xiao.w.w...@intel.com; Slava Ovsiienko ; > dev@dpdk.org > Cc: jasow...@redhat.com;

[dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

Now that we have Virtio device status support, let's only use the vDPA workaround if it is not supported. This patch also document why Virtio device status protocol feature support is strongly advised. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 16 ++-- 1 fil