Hi Eric
Please see my comments.
On 2015-04-06 19:01, Eric Kinzie wrote:
>Provide functions to allow an external 802.3ad state machine to transmit
>and recieve LACPDUs and to set the collection/distribution flags on
>slave interfaces.
>
> Signed-off-by: Eric Kinzie
> ---
> lib/librte
On 2015-04-07 16:18, Pawel Wodkowski wrote:
>
> Also, maybe a renaming "external_sm" to "state_machine_cb", set it to
> against default one and using it without "if()" will simplify code. It
> is no crucial but will eliminate couple of if's. In
> rte_eth_bond_8023ad_ext_slowtx() you can compare it
On 2015-04-06 19:01, Eric Kinzie wrote:
Interesting patch. I will closer look at this tomorrow.
For now I have first comments:
> +static void bond_mode_8023ad_ext_periodic_cb(void *arg);
> +
> #ifdef RTE_LIBRTE_BOND_DEBUG_8023AD
> #define MODE4_DEBUG(fmt, ...) RTE_LOG(DEBUG, PMD, "%6u [Port
On Tue Apr 07 16:18:08 +0200 2015, Pawel Wodkowski wrote:
> On 2015-04-06 19:01, Eric Kinzie wrote:
>
> Interesting patch. I will closer look at this tomorrow.
>
> For now I have first comments:
>
> >+static void bond_mode_8023ad_ext_periodic_cb(void *arg);
> >+
> > #ifdef RTE_LIBRTE_BOND_DEBUG
Provide functions to allow an external 802.3ad state machine to transmit
and recieve LACPDUs and to set the collection/distribution flags on
slave interfaces.
Signed-off-by: Eric Kinzie
---
lib/librte_pmd_bond/rte_eth_bond_8023ad.c | 175 +
lib/librte_pmd_bond/
5 matches
Mail list logo
