Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-03-05 Thread Thomas Monjalon
05/03/2019 10:33, Raslan Darawsheh: > Hi Stephen, > > From: Stephen Hemminger > > On Thu, 28 Feb 2019 15:49:28 + > > Raslan Darawsheh wrote: > > > > > + eth_dev->rx_pkt_burst = > > (eth_rx_burst_t)&failsafe_rx_burst; > > > + eth_dev->tx_pkt_burst = > > (eth_tx_burst_t)&fail

Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-03-05 Thread Raslan Darawsheh
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Thursday, February 28, 2019 7:25 PM > To: Raslan Darawsheh > Cc: gaetan.ri...@6wind.com; dev@dpdk.org; Thomas Monjalon > > Subject: Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary proces

Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-02-28 Thread Stephen Hemminger
On Thu, 28 Feb 2019 15:49:28 + Raslan Darawsheh wrote: > + eth_dev->rx_pkt_burst = (eth_rx_burst_t)&failsafe_rx_burst; > + eth_dev->tx_pkt_burst = (eth_tx_burst_t)&failsafe_tx_burst; Why is cast necessary here. The function signature should match.

Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-02-28 Thread Stephen Hemminger
On Thu, 28 Feb 2019 15:49:28 + Raslan Darawsheh wrote: > > static int > +devargs_already_listed(struct rte_devargs *devargs) Why not make this function bool? static bool devargs_already_listed(...)

[dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-02-28 Thread Raslan Darawsheh
Add implementation for probe in secondary. Failsafe will attempt to attach all the sub-devices in secondary process. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- drivers/net/failsafe/failsafe.c | 43 - 1 file changed, 42 insertions(