Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-24 Thread Ananyev, Konstantin
to:arybche...@solarflare.com>>; Wiles, Keith > mailto:keith.wi...@intel.com>> > Subject: Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors > stats > > 15/02/2019 19:42, Ananyev, Konstantin: > > >>> From: dev [mailto:dev-boun...@dpdk.org&l

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-20 Thread David Marchand
, Konstantin > > Cc: David Marchand ; Richardson, Bruce < > bruce.richard...@intel.com>; dev@dpdk.org; Lu, Wenzhuo > > ; Wu, Jingjing ; > Iremonger, Bernard ; Maxime Coquelin > > ; Yigit, Ferruh ; Andrew > Rybchenko ; Wiles, Keith > > > > Subject: Re: [

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-16 Thread Ananyev, Konstantin
> > On Fri, 15 Feb 2019 20:38:59 +0100 > Thomas Monjalon wrote: > > > 15/02/2019 19:42, Ananyev, Konstantin: > > > >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > > > >>> I am also for option 2 especially because of this. > > > >>> A driver that refuses a packet for r

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-16 Thread Ananyev, Konstantin
axime Coquelin > ; Yigit, Ferruh ; Andrew > Rybchenko ; Wiles, Keith > > Subject: Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors > stats > > 15/02/2019 19:42, Ananyev, Konstantin: > > >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread Stephen Hemminger
On Fri, 15 Feb 2019 20:38:59 +0100 Thomas Monjalon wrote: > 15/02/2019 19:42, Ananyev, Konstantin: > > >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > > >>> I am also for option 2 especially because of this. > > >>> A driver that refuses a packet for reason X (which is a

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread Thomas Monjalon
15/02/2019 19:42, Ananyev, Konstantin: > >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > >>> I am also for option 2 especially because of this. > >>> A driver that refuses a packet for reason X (which is a limitation, or an > >>> incorrect config or whatever that is not a

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread Ananyev, Konstantin
>>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand >>> I am also for option 2 especially because of this. >>> A driver that refuses a packet for reason X (which is a limitation, or an >>> incorrect config or whatever that is not a transient condition) but gives >>> it back to t

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread David Marchand
On Fri, Feb 15, 2019 at 7:15 PM Ananyev, Konstantin < konstantin.anan...@intel.com> wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > > I am also for option 2 especially because of this. > > A driver that refuses a packet for reason X (

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread Ananyev, Konstantin
Coquelin ; Yigit, Ferruh > ; Andrew Rybchenko ; > Wiles, Keith > Subject: Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors > stats > > On Fri, Feb 15, 2019 at 5:19 PM Thomas Monjalon wrote: > > > 15/02/2019 16:04, David Marchand: >

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread David Marchand
On Fri, Feb 15, 2019 at 5:19 PM Thomas Monjalon wrote: > 15/02/2019 16:04, David Marchand: > > On Fri, Feb 15, 2019 at 3:05 PM Bruce Richardson < > bruce.richard...@intel.com> > > wrote: > > > > > On Fri, Feb 15, 2019 at 10:33:47AM +0100, David Marchand wrote: > > > >On Fri, Feb 15, 2019 at 9

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread Thomas Monjalon
15/02/2019 16:04, David Marchand: > On Fri, Feb 15, 2019 at 3:05 PM Bruce Richardson > wrote: > > > On Fri, Feb 15, 2019 at 10:33:47AM +0100, David Marchand wrote: > > >On Fri, Feb 15, 2019 at 9:58 AM Thomas Monjalon > > ><[1]tho...@monjalon.net> wrote: > > > > > > 14/02/2019 19:51,

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread David Marchand
On Fri, Feb 15, 2019 at 3:05 PM Bruce Richardson wrote: > On Fri, Feb 15, 2019 at 10:33:47AM +0100, David Marchand wrote: > >On Fri, Feb 15, 2019 at 9:58 AM Thomas Monjalon > ><[1]tho...@monjalon.net> wrote: > > > > 14/02/2019 19:51, David Marchand: > > > What is the purpose of

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread Bruce Richardson
On Fri, Feb 15, 2019 at 10:33:47AM +0100, David Marchand wrote: >On Fri, Feb 15, 2019 at 9:58 AM Thomas Monjalon ><[1]tho...@monjalon.net> wrote: > > 14/02/2019 19:51, David Marchand: > > What is the purpose of oerrors ? > > > > Since the drivers (via rte_eth_tx_burst r

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread Wiles, Keith
> On Feb 15, 2019, at 8:05 AM, Bruce Richardson > wrote: > > On Fri, Feb 15, 2019 at 10:33:47AM +0100, David Marchand wrote: >> On Fri, Feb 15, 2019 at 9:58 AM Thomas Monjalon >> <[1]tho...@monjalon.net> wrote: >> >> 14/02/2019 19:51, David Marchand: >>> What is the purpose of oerror

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread David Marchand
On Fri, Feb 15, 2019 at 9:58 AM Thomas Monjalon wrote: > 14/02/2019 19:51, David Marchand: > > What is the purpose of oerrors ? > > > > Since the drivers (via rte_eth_tx_burst return value) report the numbers > of > > packets successfully transmitted, the application can try to retransmit > the >

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread Thomas Monjalon
14/02/2019 19:51, David Marchand: > What is the purpose of oerrors ? > > Since the drivers (via rte_eth_tx_burst return value) report the numbers of > packets successfully transmitted, the application can try to retransmit the > packets that did not make it and counts this. > If the driver counts

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-14 Thread David Marchand
On Thu, Feb 14, 2019 at 6:39 PM David Marchand wrote: > On Thu, Feb 14, 2019 at 5:30 PM Bruce Richardson < > bruce.richard...@intel.com> wrote: > >> On Thu, Feb 14, 2019 at 04:42:50PM +0100, David Marchand wrote: >> > pmd can report transmit errors but those stats are not accounted here. >> > >>

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-14 Thread David Marchand
On Thu, Feb 14, 2019 at 5:30 PM Bruce Richardson wrote: > On Thu, Feb 14, 2019 at 04:42:50PM +0100, David Marchand wrote: > > pmd can report transmit errors but those stats are not accounted here. > > > > Signed-off-by: David Marchand > > --- > > app/test-pmd/testpmd.c | 1 + > > 1 file changed

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-14 Thread Bruce Richardson
On Thu, Feb 14, 2019 at 04:42:50PM +0100, David Marchand wrote: > pmd can report transmit errors but those stats are not accounted here. > > Signed-off-by: David Marchand > --- > app/test-pmd/testpmd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pm

[dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-14 Thread David Marchand
pmd can report transmit errors but those stats are not accounted here. Signed-off-by: David Marchand --- app/test-pmd/testpmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 984155a..3acd97b 100644 --- a/app/test-pmd/testpmd.c +++ b/app