Re: [dpdk-dev] [PATCH 3/3] net/virtio: add missing read barrier for packed dequeue

2019-01-25 Thread Jens Freimann
On Thu, Jan 24, 2019 at 07:59:02PM +0300, Ilya Maximets wrote: Read barrier is required between reading the flags (desc_is_used) and the content of descriptor to ensure the ordering. Otherwise, speculative read of desc.id could be reordered with reading of the desc.flags. Fixes: a76290c8f1cf ("n

Re: [dpdk-dev] [PATCH 3/3] net/virtio: add missing read barrier for packed dequeue

2019-01-25 Thread Jens Freimann
On Thu, Jan 24, 2019 at 07:59:02PM +0300, Ilya Maximets wrote: Read barrier is required between reading the flags (desc_is_used) and the content of descriptor to ensure the ordering. Otherwise, speculative read of desc.id could be reordered with reading of the desc.flags. Fixes: a76290c8f1cf ("n

[dpdk-dev] [PATCH 3/3] net/virtio: add missing read barrier for packed dequeue

2019-01-24 Thread Ilya Maximets
Read barrier is required between reading the flags (desc_is_used) and the content of descriptor to ensure the ordering. Otherwise, speculative read of desc.id could be reordered with reading of the desc.flags. Fixes: a76290c8f1cf ("net/virtio: implement Rx path for packed queues") Cc: sta...@dpdk.