[dpdk-dev] [PATCH 2/7] examples/l3fwd-acl: enhance getopt_long usage

2020-11-24 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: ko

Re: [dpdk-dev] [PATCH 2/7] examples/l3fwd-acl: enhance getopt_long usage

2020-11-16 Thread Ibtisam Tariq
Hi Ananyev, Thank you. Mix enum with corresponding defines for string literals, is the convention of eal_options.h. You can have a look at this https://git.dpdk.org/dpdk/tree/lib/librte_eal/common/eal_options.h. On Fri, Nov 13, 2020 at 5:27 PM Ananyev, Konstantin wrote: > > Hi, > > > > > Instea

Re: [dpdk-dev] [PATCH 2/7] examples/l3fwd-acl: enhance getopt_long usage

2020-11-13 Thread Ananyev, Konstantin
Hi, > > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve readability and consistency in > all examples. > >

[dpdk-dev] [PATCH 2/7] examples/l3fwd-acl: enhance getopt_long usage

2020-11-11 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: ko