Re: [dpdk-dev] [PATCH 2/4] mk: do not build tests by default

2017-02-16 Thread Ferruh Yigit
On 2/16/2017 8:53 AM, Thomas Monjalon wrote: > 2017-02-15 17:30, Ferruh Yigit: >> On 2/15/2017 4:58 PM, Thomas Monjalon wrote: >>> 2017-02-15 15:26, Ferruh Yigit: +.PHONY: test-buid +test-build: + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig + $(Q)$(MAKE) -f $(RTE

Re: [dpdk-dev] [PATCH 2/4] mk: do not build tests by default

2017-02-16 Thread Thomas Monjalon
2017-02-15 17:30, Ferruh Yigit: > On 2/15/2017 4:58 PM, Thomas Monjalon wrote: > > 2017-02-15 15:26, Ferruh Yigit: > >> +.PHONY: test-buid > >> +test-build: > >> + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig > >> + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk test > > > > Why not r

Re: [dpdk-dev] [PATCH 2/4] mk: do not build tests by default

2017-02-15 Thread Ferruh Yigit
On 2/15/2017 4:58 PM, Thomas Monjalon wrote: > 2017-02-15 15:26, Ferruh Yigit: >> +.PHONY: test-buid >> +test-build: >> +$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig >> +$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk test > > Why not rely on default rule below? > > # all other

Re: [dpdk-dev] [PATCH 2/4] mk: do not build tests by default

2017-02-15 Thread Thomas Monjalon
2017-02-15 15:26, Ferruh Yigit: > +.PHONY: test-buid > +test-build: > + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig > + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk test Why not rely on default rule below? # all other build targets %: $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdk

[dpdk-dev] [PATCH 2/4] mk: do not build tests by default

2017-02-15 Thread Ferruh Yigit
Don't build tests with default "make" command. Require explicit command to build tests because not everybody interested in running unit tests. Following changes done in make rules: "make test-build" <--- Added "make test"<--- Updated functionality (build + run) Now "make test" builds al