Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-28 Thread Phil Yang
nux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > > ruifeng.w...@arm.com; dharmik.thak...@arm.com; n...@arm.com > > Subject: Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore > > timer armed flag > > > > On Fri, 12 Jun 2020 19:19:57 +080

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-28 Thread Phil Yang
Hi Erik, Sorry, I was on vacation. Thanks for your feedback. I will update it in the next version. Thanks, Phil > -Original Message- > From: Carrillo, Erik G > Sent: Wednesday, June 24, 2020 5:02 AM > To: Phil Yang ; dev@dpdk.org > Cc: d...@linux.vnet.ibm.com; Honnappa Nagarahalli > ; R

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-23 Thread Carrillo, Erik G
; Subject: Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore > timer armed flag > > On Fri, 12 Jun 2020 19:19:57 +0800 > Phil Yang wrote: > > > /* Track which cores have actually armed a timer */ > > struct { > > - rte_atomic16_t v;

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-23 Thread Stephen Hemminger
On Fri, 12 Jun 2020 19:19:57 +0800 Phil Yang wrote: > /* Track which cores have actually armed a timer */ > struct { > - rte_atomic16_t v; > + int16_t v; > } __rte_cache_aligned in_use[RTE_MAX_LCORE]; Do you really need this to be cache aligned (ie one p

Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-23 Thread Carrillo, Erik G
Hi Phil, Comment in-line: > -Original Message- > From: Phil Yang > Sent: Friday, June 12, 2020 6:20 AM > To: dev@dpdk.org; Carrillo, Erik G > Cc: d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; dharmik.thak...@arm.com; n...@arm.com > Subject: [PATCH 2/3] e

[dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag

2020-06-12 Thread Phil Yang
The in_use flag is a per core variable which is not shared between lcores in the normal case and the access of this variable should be ordered on the same core. However, if non-EAL thread pick the highest lcore to insert timers into, there is the possibility of conflicts on this flag between thread