Re: [dpdk-dev] [PATCH 2/3] ethdev: fail if Tx queue offload is not supported at all

2018-05-13 Thread Andrew Rybchenko
On 05/13/2018 08:37 AM, Shahaf Shuler wrote: Do not allow to request unsupported Tx offload since all checks are removed from PMDs because of consistency check in ethdev. Otherwise application may rely on offload which is not actually supported and send traffic with, for example, wrong checksums,

Re: [dpdk-dev] [PATCH 2/3] ethdev: fail if Tx queue offload is not supported at all

2018-05-13 Thread Shahaf Shuler
Sunday, May 13, 2018 8:38 AM, Shahaf Shuler: > Subject: Re: [dpdk-dev] [PATCH 2/3] ethdev: fail if Tx queue offload is not > supported at all > > -Original Message- > > From: Andrew Rybchenko > > Sent: Friday, May 11, 2018 7:26 PM > > To: dev@dpdk.org

Re: [dpdk-dev] [PATCH 2/3] ethdev: fail if Tx queue offload is not supported at all

2018-05-12 Thread Shahaf Shuler
--Shahaf > -Original Message- > From: Andrew Rybchenko > Sent: Friday, May 11, 2018 7:26 PM > To: dev@dpdk.org > Cc: Ferruh Yigit ; Thomas Monjalon > ; Shahaf Shuler ; Wei Dai > > Subject: [PATCH 2/3] ethdev: fail if Tx queue offload is not supported at all > > Do not allow to reques

[dpdk-dev] [PATCH 2/3] ethdev: fail if Tx queue offload is not supported at all

2018-05-11 Thread Andrew Rybchenko
Do not allow to request unsupported Tx offload since all checks are removed from PMDs because of consistency check in ethdev. Otherwise application may rely on offload which is not actually supported and send traffic with, for example, wrong checksums, truncated packets or packets with garbage. Fi