Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-24 Thread Coyle, David
Hi Akhil > -Original Message- > From: Akhil Goyal > Sent: Tuesday, June 23, 2020 7:38 PM > > > > > > > [DC] It's certainly an option and would work but I don't think it's > > > a good idea to > > be putting > > > protocol specific structs like this in rte_cryptodev - that's what > > > rte

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-23 Thread Akhil Goyal
Hi Konstantin/David, > > Hi David, > > > > > > > > > > > > > > > > > > /** Status of crypto operation */ @@ -121,6 +123,13 @@ struct > > > > > > rte_crypto_op { > > > > > > struct rte_crypto_asym_op asym[0]; > > > > > > /**< Asymmetric operation parameters */ > > > > > >

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-11 Thread Coyle, David
Hi Konstantin, > > > > > > > > > > > > > > > > > /** Status of crypto operation */ @@ -121,6 +123,13 @@ struct > > > > > > rte_crypto_op { > > > > > > struct rte_crypto_asym_op asym[0]; > > > > > > /**< Asymmetric operation parameters */ > > > > > > > > > > > > +#ifdef RTE

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-11 Thread Ananyev, Konstantin
Hi David, > > > > > > > > > > > > > > /** Status of crypto operation */ @@ -121,6 +123,13 @@ struct > > > > > rte_crypto_op { > > > > > struct rte_crypto_asym_op asym[0]; > > > > > /**< Asymmetric operation parameters */ > > > > > > > > > > +#ifdef RTE_LIBRTE_SECURITY

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-10 Thread Coyle, David
Hi Konstantin, > > > > > > > > > > > /** Status of crypto operation */ @@ -121,6 +123,13 @@ struct > > > > rte_crypto_op { > > > > struct rte_crypto_asym_op asym[0]; > > > > /**< Asymmetric operation parameters */ > > > > > > > > +#ifdef RTE_LIBRTE_SECURITY > > > >

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-10 Thread Ananyev, Konstantin
Hi David, > > > > > > > > /** Status of crypto operation */ > > > @@ -121,6 +123,13 @@ struct rte_crypto_op { > > > struct rte_crypto_asym_op asym[0]; > > > /**< Asymmetric operation parameters */ > > > > > > +#ifdef RTE_LIBRTE_SECURITY > > > + uint8_t security[0];

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-09 Thread Coyle, David
Hi Konstantin, see below > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, June 9, 2020 2:23 PM > > > > > > /** Status of crypto operation */ > > @@ -121,6 +123,13 @@ struct rte_crypto_op { > > struct rte_crypto_asym_op asym[0]; > > /**< Asymmetr

Re: [dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-09 Thread Ananyev, Konstantin
> > Add a new security operation structure to the crypto operation to allow > protocol specific parameters defined in rte_security be defined for a > crypto operation. > > Please note this is API changes only. Implementation will follow in > next version. > > Signed-off-by: David Coyle > Sign

[dpdk-dev] [PATCH 2/3] cryptodev: add security operation to crypto operation

2020-06-04 Thread David Coyle
Add a new security operation structure to the crypto operation to allow protocol specific parameters defined in rte_security be defined for a crypto operation. Please note this is API changes only. Implementation will follow in next version. Signed-off-by: David Coyle Signed-off-by: Mairtin o Lo