Re: [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update

2021-09-14 Thread Nélio Laranjeiro
+Shahaf, Hi Maxime, On Mon, Sep 13, 2021 at 11:41:04AM +0200, Maxime Coquelin wrote: > Hi Nélio, > > On 9/10/21 4:16 PM, Nélio Laranjeiro wrote: > > On Fri, Sep 10, 2021 at 01:06:53PM +0300, Andrew Rybchenko wrote: > >> On 9/10/21 12:57 PM, Maxime Coquelin wrote: > >>> > >>> > >>> On 9/10/21 11:

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update

2021-09-13 Thread Maxime Coquelin
Hi Nélio, On 9/10/21 4:16 PM, Nélio Laranjeiro wrote: > On Fri, Sep 10, 2021 at 01:06:53PM +0300, Andrew Rybchenko wrote: >> On 9/10/21 12:57 PM, Maxime Coquelin wrote: >>> >>> >>> On 9/10/21 11:51 AM, Andrew Rybchenko wrote: On 9/10/21 12:17 PM, Maxime Coquelin wrote: > port_rss_hash_key

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update

2021-09-10 Thread Nélio Laranjeiro
On Fri, Sep 10, 2021 at 01:06:53PM +0300, Andrew Rybchenko wrote: > On 9/10/21 12:57 PM, Maxime Coquelin wrote: > > > > > > On 9/10/21 11:51 AM, Andrew Rybchenko wrote: > >> On 9/10/21 12:17 PM, Maxime Coquelin wrote: > >>> port_rss_hash_key_update() initializes rss_conf with the > >>> RSS hash t

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update

2021-09-10 Thread Andrew Rybchenko
On 9/10/21 12:57 PM, Maxime Coquelin wrote: > > > On 9/10/21 11:51 AM, Andrew Rybchenko wrote: >> On 9/10/21 12:17 PM, Maxime Coquelin wrote: >>> port_rss_hash_key_update() initializes rss_conf with the >>> RSS hash type and key provided by the user, but it calls >>> rte_eth_dev_rss_hash_conf_get

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update

2021-09-10 Thread Maxime Coquelin
On 9/10/21 11:51 AM, Andrew Rybchenko wrote: > On 9/10/21 12:17 PM, Maxime Coquelin wrote: >> port_rss_hash_key_update() initializes rss_conf with the >> RSS hash type and key provided by the user, but it calls >> rte_eth_dev_rss_hash_conf_get() before calling >> rte_eth_dev_rss_hash_update(), w

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update

2021-09-10 Thread Andrew Rybchenko
On 9/10/21 12:17 PM, Maxime Coquelin wrote: > port_rss_hash_key_update() initializes rss_conf with the > RSS hash type and key provided by the user, but it calls > rte_eth_dev_rss_hash_conf_get() before calling > rte_eth_dev_rss_hash_update(), which overides the parsed > config with current NIC's c

[dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update

2021-09-10 Thread Maxime Coquelin
port_rss_hash_key_update() initializes rss_conf with the RSS hash type and key provided by the user, but it calls rte_eth_dev_rss_hash_conf_get() before calling rte_eth_dev_rss_hash_update(), which overides the parsed config with current NIC's config. While the RSS key value is set again after, th