[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-10-14 Thread David Marchand
On Wed, Oct 14, 2015 at 10:00 AM, David Marchand wrote: > > I am testing Thomas proposal (just moving the intr_init() call), else I > will rebase this patch. > Thomas approach works and is minimal. I ran some autotest, did not see anything wrong (let aside the tests that already fail on current

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-10-14 Thread David Marchand
On Wed, Oct 14, 2015 at 2:07 AM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Thu, 1 Oct 2015 07:25:45 -0400 > Neil Horman wrote: > > > On Wed, Sep 30, 2015 at 05:37:05PM +0200, Thomas Monjalon wrote: > > > 2015-09-30 10:52, Neil Horman: > > > > I think it may be solved by calli

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-10-13 Thread Stephen Hemminger
On Thu, 1 Oct 2015 07:25:45 -0400 Neil Horman wrote: > On Wed, Sep 30, 2015 at 05:37:05PM +0200, Thomas Monjalon wrote: > > 2015-09-30 10:52, Neil Horman: > > > On Wed, Sep 30, 2015 at 10:28:53AM +0200, David Marchand wrote: > > > > On Tue, Sep 29, 2015 at 9:25 PM, Stephen Hemminger < > > > > ste

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-10-12 Thread Stephen Hemminger
I think David's patch should be in 2.2 (and 2.1.X if that starts out). It solves the problem for both link state and secondary processes. It may need to be updated for the current drivers/net/virtio layout.

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-10-01 Thread Neil Horman
On Wed, Sep 30, 2015 at 05:37:05PM +0200, Thomas Monjalon wrote: > 2015-09-30 10:52, Neil Horman: > > On Wed, Sep 30, 2015 at 10:28:53AM +0200, David Marchand wrote: > > > On Tue, Sep 29, 2015 at 9:25 PM, Stephen Hemminger < > > > stephen at networkplumber.org> wrote: > > > > > > > On Tue, 10 Mar

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-09-30 Thread Thomas Monjalon
2015-09-30 10:52, Neil Horman: > On Wed, Sep 30, 2015 at 10:28:53AM +0200, David Marchand wrote: > > On Tue, Sep 29, 2015 at 9:25 PM, Stephen Hemminger < > > stephen at networkplumber.org> wrote: > > > > > On Tue, 10 Mar 2015 09:14:28 -0400 > > > Neil Horman wrote: > > > > I don't see how this wo

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-09-30 Thread Neil Horman
On Wed, Sep 30, 2015 at 10:28:53AM +0200, David Marchand wrote: > On Tue, Sep 29, 2015 at 9:25 PM, Stephen Hemminger < > stephen at networkplumber.org> wrote: > > > On Tue, 10 Mar 2015 09:14:28 -0400 > > Neil Horman wrote: > > > > > > > > I don't see how this works for all cases. The constructor

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-09-30 Thread David Marchand
On Tue, Sep 29, 2015 at 9:25 PM, Stephen Hemminger < stephen at networkplumber.org> wrote: > On Tue, 10 Mar 2015 09:14:28 -0400 > Neil Horman wrote: > > > > > I don't see how this works for all cases. The constructor is called > once when > > the library is first loaded. What if you have multip

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-09-30 Thread Stephen Hemminger
On Wed, 30 Sep 2015 17:37:05 +0200 Thomas Monjalon wrote: > 2015-09-30 10:52, Neil Horman: > > On Wed, Sep 30, 2015 at 10:28:53AM +0200, David Marchand wrote: > > > On Tue, Sep 29, 2015 at 9:25 PM, Stephen Hemminger < > > > stephen at networkplumber.org> wrote: > > > > > > > On Tue, 10 Mar 2015

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-09-29 Thread Stephen Hemminger
On Tue, 10 Mar 2015 09:14:28 -0400 Neil Horman wrote: > On Mon, Mar 09, 2015 at 03:56:39PM +0100, David Marchand wrote: > > Playing with virtio link status triggers a segfault because of an incorrect > > io > > privilege level. > > > > To reproduce the problem, virtio device must be bound to ig

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-03-10 Thread Neil Horman
On Mon, Mar 09, 2015 at 03:56:39PM +0100, David Marchand wrote: > Playing with virtio link status triggers a segfault because of an incorrect io > privilege level. > > To reproduce the problem, virtio device must be bound to igb_uio to have lsc > enabled. > > $ lspci |grep Ethernet > 00:03.0 Ethe

[dpdk-dev] [PATCH 2/2] virtio: change io privilege level as early as possible

2015-03-09 Thread David Marchand
Playing with virtio link status triggers a segfault because of an incorrect io privilege level. To reproduce the problem, virtio device must be bound to igb_uio to have lsc enabled. $ lspci |grep Ethernet 00:03.0 Ethernet controller: Red Hat, Inc Virtio network device $ modprobe uio $ insmod ./x8