Re: [dpdk-dev] [PATCH 2/2] net/tap: add tun log and documnetation

2018-04-03 Thread Pascal Mazon
Ok Ferruh, I missed that. Apart for the type in "documentation" the patches are ok with me. Acked-by: Pascal Mazon On 03/04/2018 12:05, Ferruh Yigit wrote: > On 4/3/2018 9:27 AM, Pascal Mazon wrote: >> Hi, >> >> I'm not sure why you split this patch in two. >> It seemed to me that it was fine to

Re: [dpdk-dev] [PATCH 2/2] net/tap: add tun log and documnetation

2018-04-03 Thread Ferruh Yigit
On 4/3/2018 9:27 AM, Pascal Mazon wrote: > Hi, > > I'm not sure why you split this patch in two. > It seemed to me that it was fine to change the doc+logs in the same > patch as the code. > Especially since documentation change is very small. It was my suggestion indeed, to separate actual functi

Re: [dpdk-dev] [PATCH 2/2] net/tap: add tun log and documnetation

2018-04-03 Thread Ferruh Yigit
On 4/3/2018 9:27 AM, Pascal Mazon wrote: > Hi, > > I'm not sure why you split this patch in two. > It seemed to me that it was fine to change the doc+logs in the same > patch as the code. > Especially since documentation change is very small. It was my suggestion indeed, to separate actual functi

Re: [dpdk-dev] [PATCH 2/2] net/tap: add tun log and documnetation

2018-04-03 Thread Pascal Mazon
Hi, I'm not sure why you split this patch in two. It seemed to me that it was fine to change the doc+logs in the same patch as the code. Especially since documentation change is very small. Anyway, there's just the "documnetation" typo in the commit title, otherwise it's fine by me. Best regards

[dpdk-dev] [PATCH 2/2] net/tap: add tun log and documnetation

2018-04-02 Thread Vipin Varghese
The changes add TUN|TAP specific logs and documentation support. Signed-off-by: Vipin Varghese --- doc/guides/nics/tap.rst | 15 +-- drivers/net/tap/rte_eth_tap.c | 28 2 files changed, 29 insertions(+), 14 deletions(-) diff --git a/doc/guides/nics