Re: [dpdk-dev] [PATCH 2/2] net/mlx5: reduce unnecessary memory access

2021-07-02 Thread Ruifeng Wang
> -Original Message- > From: Slava Ovsiienko > Sent: Friday, July 2, 2021 3:06 PM > To: Ruifeng Wang ; Raslan Darawsheh > ; Matan Azrad ; Shahaf Shuler > > Cc: dev@dpdk.org; jer...@marvell.com; nd ; Honnappa > Nagarahalli > Subject: RE: [PATCH 2/2] net/mlx5: reduce unnecessary memory acc

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: reduce unnecessary memory access

2021-07-02 Thread Slava Ovsiienko
Hi, Ruifeng Could we go further and implement loop inside the conditional? Like this: if (mlx5_mr_btree_len(&rxq->mr_ctrl.cache_bh) > 1) { for (i = 0; i < n; ++i) { void *buf_addr = elts[i]->buf_addr; wq[i].addr = rte_cpu_to_be_64((uintptr_t)buf_addr +

[dpdk-dev] [PATCH 2/2] net/mlx5: reduce unnecessary memory access

2021-06-01 Thread Ruifeng Wang
MR btree len is a constant during Rx replenish. Moved retrieve of the value out of loop to reduce data loads. Slight performance uplift was measured on N1SDP. Signed-off-by: Ruifeng Wang --- drivers/net/mlx5/mlx5_rxtx_vec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git