Re: [dpdk-dev] [PATCH 2/2] net/ice: disable advanced features in safe mode

2019-03-01 Thread Stillwell Jr, Paul M
: [dpdk-dev] [PATCH 2/2] net/ice: disable advanced features in safe mode As some advanced features are not supported in safe mode, this patch disabled them when safe mode flags is set. Signed-off-by: Qiming Yang --- drivers/net/ice/ice_ethdev.c | 30 ++ 1 file changed, 30

Re: [dpdk-dev] [PATCH 2/2] net/ice: disable advanced features in safe mode

2019-03-01 Thread Stephen Hemminger
On Fri, 1 Mar 2019 20:46:13 +0800 Qiming Yang wrote: > + PMD_INIT_LOG(WARNING, "Initialize in safe mode," > + "some features are disabled.\n"); Don't split a message string, it makes it harder to search. Also, most drivers define PMD_INIT_LOG to always add a newline and do not

[dpdk-dev] [PATCH 2/2] net/ice: disable advanced features in safe mode

2019-02-28 Thread Qiming Yang
As some advanced features are not supported in safe mode, this patch disabled them when safe mode flags is set. Signed-off-by: Qiming Yang --- drivers/net/ice/ice_ethdev.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/n