Re: [dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off'

2018-09-18 Thread Dan Gora
On Tue, Sep 18, 2018 at 1:48 PM, Ferruh Yigit wrote: > I just read the other thread, including Igor's and your comment about starting > the interface down, overall I got your point but my concerns is if someone > has a > solution based on assumption that interface will be up when created will be

Re: [dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off'

2018-09-18 Thread Ferruh Yigit
On 9/18/2018 5:15 PM, Ferruh Yigit wrote: > On 9/12/2018 12:29 AM, Dan Gora wrote: >> Set the carrier state to 'off' when the interface is instantiated >> or when it is marked 'up' or 'down'. This is necessary to set the >> interface to a known operational state until the carrier state is >> chang

Re: [dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off'

2018-09-18 Thread Ferruh Yigit
On 9/12/2018 12:29 AM, Dan Gora wrote: > Set the carrier state to 'off' when the interface is instantiated > or when it is marked 'up' or 'down'. This is necessary to set the > interface to a known operational state until the carrier state is > changed with rte_kni_update_link(). Why setting to n

[dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off'

2018-09-11 Thread Dan Gora
Set the carrier state to 'off' when the interface is instantiated or when it is marked 'up' or 'down'. This is necessary to set the interface to a known operational state until the carrier state is changed with rte_kni_update_link(). Signed-off-by: Dan Gora --- kernel/linux/kni/kni_misc.c | 2 +