Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-07-24 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, July 24, 2018 1:50 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Nicolau, Radu > Subject: Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option > parsi

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-07-24 Thread Akhil Goyal
Cc: Nicolau, Radu Subject: Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing On 6/22/2018 3:40 PM, Ananyev, Konstantin wrote: -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Friday, June 22, 2018 11:01 AM To: Ananyev, Konstantin ; dev

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-07-24 Thread Ananyev, Konstantin
antin ; dev@dpdk.org > >> Cc: Nicolau, Radu > >> Subject: Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask > >> option parsing > >> > >> > >> > >> On 6/22/2018 3:40 PM, Ananyev, Konstantin wrote: > >>>>

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-07-24 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Thursday, July 5, 2018 10:03 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Nicolau, Radu > Subject: Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-07-05 Thread Akhil Goyal
: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing Hi Konstantin, On 6/5/2018 7:46 PM, Konstantin Ananyev wrote: parse_portmask() returns both portmask value and possible error code as 32-bit integer. That causes some confusion for callers. Split error code and portmask

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-06-22 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, June 22, 2018 11:41 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Nicolau, Radu > Subject: Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option > parsing >

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-06-22 Thread Akhil Goyal
On 6/22/2018 3:40 PM, Ananyev, Konstantin wrote: -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Friday, June 22, 2018 11:01 AM To: Ananyev, Konstantin ; dev@dpdk.org Cc: Nicolau, Radu Subject: Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-06-22 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, June 22, 2018 11:01 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Nicolau, Radu > Subject: Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option > parsi

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-06-22 Thread Akhil Goyal
/ipsec-secgw: fix portmask option parsing Hi Konstantin, On 6/5/2018 7:46 PM, Konstantin Ananyev wrote: parse_portmask() returns both portmask value and possible error code as 32-bit integer. That causes some confusion for callers. Split error code and portmask value into two distinct variables

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-06-21 Thread Ananyev, Konstantin
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, June 21, 2018 2:49 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Nicolau, Radu > Subject: Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-06-21 Thread Akhil Goyal
Hi Konstantin, On 6/5/2018 7:46 PM, Konstantin Ananyev wrote: parse_portmask() returns both portmask value and possible error code as 32-bit integer. That causes some confusion for callers. Split error code and portmask value into two distinct variables. Also allows to run the app with unprotect

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-06-05 Thread Iremonger, Bernard
Hi Konstantin, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Konstantin Ananyev > Sent: Tuesday, June 5, 2018 3:16 PM > To: dev@dpdk.org; dev@dpdk.org > Cc: Ananyev, Konstantin ; Nicolau, Radu > > Subject: [dpdk-dev] [PATCH 2/2] exam

[dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

2018-06-05 Thread Konstantin Ananyev
parse_portmask() returns both portmask value and possible error code as 32-bit integer. That causes some confusion for callers. Split error code and portmask value into two distinct variables. Also allows to run the app with unprotected_port_mask == 0. Fixes: d299106e8e31 ("examples/ipsec-secgw: a