Re: [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic

2021-04-09 Thread David Marchand
On Thu, Apr 8, 2021 at 8:02 PM Luc Pelletier wrote: > > > Thank you for these 2 fixes. Note the the title of your patches do not > > contain the version (should have been v8?). I don't know how critical > > it is for commiters. > > Thanks Olivier. I'll admit that I wasn't sure if I should version

Re: [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic

2021-04-08 Thread Luc Pelletier
> Thank you for these 2 fixes. Note the the title of your patches do not > contain the version (should have been v8?). I don't know how critical > it is for commiters. Thanks Olivier. I'll admit that I wasn't sure if I should version the patches after splitting the original. I opted not to but it

Re: [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic

2021-04-08 Thread Honnappa Nagarahalli
> > The affinity of a control thread is set after it has been launched. If > setting the > affinity fails, pthread_cancel is called followed by a call to pthread_join, > which > can hang forever if the thread's start routine doesn't call a pthread > cancellation point. > > This patch modifies

Re: [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic

2021-04-08 Thread Olivier Matz
Hi Luc, On Wed, Apr 07, 2021 at 04:16:06PM -0400, Luc Pelletier wrote: > The affinity of a control thread is set after it has been launched. If > setting the affinity fails, pthread_cancel is called followed by a call > to pthread_join, which can hang forever if the thread's start routine > doesn'

[dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic

2021-04-07 Thread Luc Pelletier
The affinity of a control thread is set after it has been launched. If setting the affinity fails, pthread_cancel is called followed by a call to pthread_join, which can hang forever if the thread's start routine doesn't call a pthread cancellation point. This patch modifies the logic so that the