Re: [dpdk-dev] [PATCH 16/20] ethdev: remove old close behaviour

2020-09-24 Thread Rasesh Mody
Hi Thomas, Ferruh, >From: dev On Behalf Of Ferruh Yigit >Sent: Wednesday, September 23, 2020 9:45 AM > >On 9/13/2020 11:07 PM, Thomas Monjalon wrote: >> The temporary flag RTE_ETH_DEV_CLOSE_REMOVE is removed. >> It was introduced in DPDK 18.11 in order to give time for PMDs to migrate. >> >> The

Re: [dpdk-dev] [PATCH 16/20] ethdev: remove old close behaviour

2020-09-24 Thread Ferruh Yigit
On 9/23/2020 9:41 PM, Thomas Monjalon wrote: 23/09/2020 18:44, Ferruh Yigit: On 9/13/2020 11:07 PM, Thomas Monjalon wrote: * Note 3: The port is supposed to be in a stopped state when it is closed. If it is not the case, it is free to the PMD implementation how to react when trying to close a n

Re: [dpdk-dev] [PATCH 16/20] ethdev: remove old close behaviour

2020-09-23 Thread Thomas Monjalon
23/09/2020 18:44, Ferruh Yigit: > On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > > * Note 3: > > The port is supposed to be in a stopped state when it is closed. > > If it is not the case, it is free to the PMD implementation > > how to react when trying to close a non-stopped port: > > either try

Re: [dpdk-dev] [PATCH 16/20] ethdev: remove old close behaviour

2020-09-23 Thread Ferruh Yigit
On 9/13/2020 11:07 PM, Thomas Monjalon wrote: The temporary flag RTE_ETH_DEV_CLOSE_REMOVE is removed. It was introduced in DPDK 18.11 in order to give time for PMDs to migrate. The old behaviour was to free only queues when closing a port. The new behaviour is calling rte_eth_dev_release_port()

[dpdk-dev] [PATCH 16/20] ethdev: remove old close behaviour

2020-09-13 Thread Thomas Monjalon
The temporary flag RTE_ETH_DEV_CLOSE_REMOVE is removed. It was introduced in DPDK 18.11 in order to give time for PMDs to migrate. The old behaviour was to free only queues when closing a port. The new behaviour is calling rte_eth_dev_release_port() which does three more tasks: - trigger e