Re: [dpdk-dev] [PATCH 10/15] net/octeontx2: switch timestamp to dynamic mbuf field

2020-11-01 Thread Andrew Rybchenko
On 10/30/20 3:41 PM, Jerin Jacob wrote: On Thu, Oct 29, 2020 at 5:22 PM Slava Ovsiienko wrote: Just five cents - exporting the offset (making it global) might have side effect impacting the performance. I agree with Slava. The offset value should be stored in the PMD structure. IMO, We can h

Re: [dpdk-dev] [PATCH 10/15] net/octeontx2: switch timestamp to dynamic mbuf field

2020-11-01 Thread Thomas Monjalon
30/10/2020 13:41, Jerin Jacob: > On Thu, Oct 29, 2020 at 5:22 PM Slava Ovsiienko > wrote: > > From: Andrew Rybchenko > > > > Just five cents - exporting the offset (making it global) might have side > > effect impacting the performance. > > I agree with Slava. The offset value should be store

Re: [dpdk-dev] [PATCH 10/15] net/octeontx2: switch timestamp to dynamic mbuf field

2020-10-30 Thread Jerin Jacob
On Thu, Oct 29, 2020 at 5:22 PM Slava Ovsiienko wrote: > > Just five cents - exporting the offset (making it global) might have side > effect impacting the performance. I agree with Slava. The offset value should be stored in the PMD structure. IMO, We can have an ethdev API to get the offset a

Re: [dpdk-dev] [PATCH 10/15] net/octeontx2: switch timestamp to dynamic mbuf field

2020-10-29 Thread Slava Ovsiienko
Just five cents - exporting the offset (making it global) might have side effect impacting the performance. Offset might be located in some memory sharing the cacheline with some other variables. If these variables are writable and are being updated frequently - we might get the cache contentio

Re: [dpdk-dev] [PATCH 10/15] net/octeontx2: switch timestamp to dynamic mbuf field

2020-10-29 Thread Andrew Rybchenko
On 10/29/20 2:34 PM, Thomas Monjalon wrote: > 29/10/2020 12:02, Andrew Rybchenko: >> On 10/29/20 12:27 PM, Thomas Monjalon wrote: >>> +/* variables are exported because this file is included in other drivers */ >>> +extern uint64_t rte_pmd_octeontx2_timestamp_rx_dynflag; >>> +extern int rte_pmd_oct

Re: [dpdk-dev] [PATCH 10/15] net/octeontx2: switch timestamp to dynamic mbuf field

2020-10-29 Thread Thomas Monjalon
29/10/2020 12:02, Andrew Rybchenko: > On 10/29/20 12:27 PM, Thomas Monjalon wrote: > > +/* variables are exported because this file is included in other drivers */ > > +extern uint64_t rte_pmd_octeontx2_timestamp_rx_dynflag; > > +extern int rte_pmd_octeontx2_timestamp_dynfield_offset; > > + > > +st

Re: [dpdk-dev] [PATCH 10/15] net/octeontx2: switch timestamp to dynamic mbuf field

2020-10-29 Thread Andrew Rybchenko
On 10/29/20 12:27 PM, Thomas Monjalon wrote: > The mbuf timestamp is moved to a dynamic field > in order to allow removal of the deprecated static field. > The related mbuf flag is also replaced. > > Signed-off-by: Thomas Monjalon > --- > drivers/net/octeontx2/otx2_ethdev.c | 33

[dpdk-dev] [PATCH 10/15] net/octeontx2: switch timestamp to dynamic mbuf field

2020-10-29 Thread Thomas Monjalon
The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced. Signed-off-by: Thomas Monjalon --- drivers/net/octeontx2/otx2_ethdev.c | 33 + drivers/net/octeontx2/otx2_rx.h | 19 +++