[dpdk-dev] [PATCH 1.6.1] don't inline rte_string_fns

2014-04-17 Thread Thomas Monjalon
Hi Stephen, This patch is still pending. Please send a v2. 2014-03-20 17:30, Thomas Monjalon: > Hi, > > I have some minor comments below. > > 27/02/2014 09:18, Stephen Hemminger : > > The function rte_snprintf() can never be inlined by Gcc. > > > > If compiled with -Winline it generates an erro

[dpdk-dev] [PATCH 1.6.1] don't inline rte_string_fns

2014-03-20 Thread Thomas Monjalon
Hi, I have some minor comments below. 27/02/2014 09:18, Stephen Hemminger : > The function rte_snprintf() can never be inlined by Gcc. > If compiled with -Winline it generates an error: > function ?rte_snprintf? can never be inlined because it uses variable > argument lists [-Werror=inline] > >

[dpdk-dev] [PATCH 1.6.1] don't inline rte_string_fns

2014-02-27 Thread Stephen Hemminger
The function rte_snprintf() can never be inlined by Gcc. If compiled with -Winline it generates an error: function ?rte_snprintf? can never be inlined because it uses variable argument lists [-Werror=inline] Therefore since both rte_snprintf and rte_strsplit are not performance sensitive just m