Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-03 Thread Bruce Richardson
On Tue, Nov 03, 2020 at 10:45:37AM +0100, David Marchand wrote: > On Tue, Nov 3, 2020 at 10:19 AM David Marchand > wrote: > > > > On Tue, Nov 3, 2020 at 10:06 AM Thomas Monjalon wrote: > > > > > > 03/11/2020 09:19, David Marchand: > > > > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon > > > > w

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-03 Thread David Marchand
On Tue, Nov 3, 2020 at 10:19 AM David Marchand wrote: > > On Tue, Nov 3, 2020 at 10:06 AM Thomas Monjalon wrote: > > > > 03/11/2020 09:19, David Marchand: > > > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon > > > wrote: > > > > > > -name = 'octeontx2_regex' > > > > > > > > But it is not the sa

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-03 Thread David Marchand
On Tue, Nov 3, 2020 at 10:06 AM Thomas Monjalon wrote: > > 03/11/2020 09:19, David Marchand: > > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon wrote: > > > > > -name = 'octeontx2_regex' > > > > > > But it is not the same? > > > > > > The name will default to "octeontx2", which is fine. > > > But

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-03 Thread Thomas Monjalon
03/11/2020 09:19, David Marchand: > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon wrote: > > > > -name = 'octeontx2_regex' > > > > But it is not the same? > > > > The name will default to "octeontx2", which is fine. > > But the fmt_name should not take this default. > > I believe fmt_name should

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-03 Thread David Marchand
On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon wrote: > > > -name = 'octeontx2_regex' > > But it is not the same? > > The name will default to "octeontx2", which is fine. > But the fmt_name should not take this default. > I believe fmt_name should be "octeontx2_regex" as I did in my patch. fmt_na

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-02 Thread Thomas Monjalon
02/11/2020 20:48, David Marchand: > On Mon, Nov 2, 2020 at 6:45 PM Bruce Richardson > wrote: > > > > Since the device class is now part of the standard filenames, it's no > > longer needed in name overrides in specific drivers. > > > > Fixes: a20b2c01a7a1 ("build: standardize component names and d

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-02 Thread David Marchand
On Mon, Nov 2, 2020 at 6:45 PM Bruce Richardson wrote: > > Since the device class is now part of the standard filenames, it's no > longer needed in name overrides in specific drivers. > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > Signed-off-by: Bruce Richardson E

[dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-02 Thread Bruce Richardson
Since the device class is now part of the standard filenames, it's no longer needed in name overrides in specific drivers. Fixes: a20b2c01a7a1 ("build: standardize component names and defines") Signed-off-by: Bruce Richardson --- drivers/regex/octeontx2/meson.build | 1 - 1 file changed, 1 dele