Re: [dpdk-dev] [PATCH 1/8] cryptodev: separate out internal structures

2021-09-13 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Sunday, August 29, 2021 1:52 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; Nicolau, Radu ; Doherty, > Declan ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Zhang, Roy Fan ; > asoma...@amd.com; ru

Re: [dpdk-dev] [PATCH 1/8] cryptodev: separate out internal structures

2021-09-08 Thread Akhil Goyal
Hi Anoob, Please see inline. > > > > +#include > > [Anoob] Is this intentional? Shouldn't we keep includes together in the top of > the file? > It is intentional, and will be removed in a later patch, when the new framework is ready. > > +/** > > + * > > [Anoob] Is there an extra blank line?

Re: [dpdk-dev] [PATCH 1/8] cryptodev: separate out internal structures

2021-09-08 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > Subject: [PATCH 1/8] cryptodev: separate out internal structures > > A new header file rte_cryptodev_core.h is added and all internal data > structures which need not be exposed directly to application are moved to > this file. These structures are m

[dpdk-dev] [PATCH 1/8] cryptodev: separate out internal structures

2021-08-29 Thread Akhil Goyal
A new header file rte_cryptodev_core.h is added and all internal data structures which need not be exposed directly to application are moved to this file. These structures are mostly used by drivers, but they need to be in the public header file as they are accessed by datapath inline functions for