Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file

2020-04-23 Thread Ranjit Menon
On 4/23/2020 3:48 AM, Thomas Monjalon wrote: 23/04/2020 11:06, Dmitry Kozlyuk: On 2020-04-23 09:27 GMT+0200 Thomas Monjalon wrote: 23/04/2020 01:51, Ranjit Menon: On 4/22/2020 12:27 AM, tal...@mellanox.com wrote: From: Tal Shnaiderman Move common functions between Unix and Windows to eal_co

Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file

2020-04-23 Thread Thomas Monjalon
23/04/2020 11:06, Dmitry Kozlyuk: > On 2020-04-23 09:27 GMT+0200 Thomas Monjalon wrote: > > 23/04/2020 01:51, Ranjit Menon: > > > On 4/22/2020 12:27 AM, tal...@mellanox.com wrote: > > > > From: Tal Shnaiderman > > > > > > > > Move common functions between Unix and Windows to eal_config.c. > >

Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file

2020-04-23 Thread Dmitry Kozlyuk
On 2020-04-23 09:27 GMT+0200 Thomas Monjalon wrote: > 23/04/2020 01:51, Ranjit Menon: > > On 4/22/2020 12:27 AM, tal...@mellanox.com wrote: > > > From: Tal Shnaiderman > > > > > > Move common functions between Unix and Windows to eal_config.c. > > > > Like other files in common, we should ca

Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file

2020-04-23 Thread Thomas Monjalon
23/04/2020 01:51, Ranjit Menon: > On 4/22/2020 12:27 AM, tal...@mellanox.com wrote: > > From: Tal Shnaiderman > > > > Move common functions between Unix and Windows to eal_config.c. > > Like other files in common, we should call this eal_common_config.c I am not sure about the interest of repea

Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file

2020-04-22 Thread Ranjit Menon
On 4/22/2020 12:27 AM, tal...@mellanox.com wrote: From: Tal Shnaiderman Move common functions between Unix and Windows to eal_config.c. Like other files in common, we should call this eal_common_config.c Those simple functions are getter functions for IOVA, configuration, Multi-process. M

[dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file

2020-04-22 Thread talshn
From: Tal Shnaiderman Move common functions between Unix and Windows to eal_config.c. Those simple functions are getter functions for IOVA, configuration, Multi-process. Move rte_config and runtime_dir to be defined in a common file. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/common/e