Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names

2018-01-18 Thread Thomas Monjalon
18/01/2018 08:52, Andrew Rybchenko: > On 01/18/2018 10:16 AM, Andrew Rybchenko wrote: > > On 01/17/2018 08:33 PM, Thomas Monjalon wrote: > >> Hi, 2 comments below > >> > >> 11/01/2018 09:12, Andrew Rybchenko: > >>> From: Ivan Malov > >>> > >>> +#defineRTE_RX_OFFLOAD_BIT2STR(_name)\ > >>> +

Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names

2018-01-17 Thread Andrew Rybchenko
On 01/18/2018 10:16 AM, Andrew Rybchenko wrote: On 01/17/2018 08:33 PM, Thomas Monjalon wrote: Hi, 2 comments below 11/01/2018 09:12, Andrew Rybchenko: From: Ivan Malov +#define    RTE_RX_OFFLOAD_BIT2STR(_name)    \ +    { DEV_RX_OFFLOAD_##_name, #_name } + +static const struct { +    uint64

Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names

2018-01-17 Thread Andrew Rybchenko
On 01/17/2018 08:33 PM, Thomas Monjalon wrote: Hi, 2 comments below 11/01/2018 09:12, Andrew Rybchenko: From: Ivan Malov +#defineRTE_RX_OFFLOAD_BIT2STR(_name) \ + { DEV_RX_OFFLOAD_##_name, #_name } + +static const struct { + uint64_t offload; + const char *name; +}

Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names

2018-01-17 Thread Shahaf Shuler
Wednesday, January 17, 2018 7:33 PM, Thomas Monjalon: 09:12, Andrew Rybchenko: > > From: Ivan Malov > > > > +#defineRTE_RX_OFFLOAD_BIT2STR(_name) \ > > + { DEV_RX_OFFLOAD_##_name, #_name } > > + > > +static const struct { > > + uint64_t offload; > > + const char *name; > > +} rte_rx_of

Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names

2018-01-17 Thread Thomas Monjalon
Hi, 2 comments below 11/01/2018 09:12, Andrew Rybchenko: > From: Ivan Malov > > +#define RTE_RX_OFFLOAD_BIT2STR(_name) \ > + { DEV_RX_OFFLOAD_##_name, #_name } > + > +static const struct { > + uint64_t offload; > + const char *name; > +} rte_rx_offload_names[] = { > + RTE_

Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names

2018-01-17 Thread Thomas Monjalon
17/01/2018 17:55, Ferruh Yigit: > On 1/11/2018 8:12 AM, Andrew Rybchenko wrote: > > From: Ivan Malov > > > > Commonly, drivers converted to the new offload API > > may need to log unsupported offloads as a response > > to wrong settings. From this perspective, it would > > be convenient to have g

Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names

2018-01-17 Thread Ferruh Yigit
On 1/11/2018 8:12 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > Commonly, drivers converted to the new offload API > may need to log unsupported offloads as a response > to wrong settings. From this perspective, it would > be convenient to have generic functions to look up > offload names. T

[dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names

2018-01-11 Thread Andrew Rybchenko
From: Ivan Malov Commonly, drivers converted to the new offload API may need to log unsupported offloads as a response to wrong settings. From this perspective, it would be convenient to have generic functions to look up offload names. The patch adds such a helper for Rx. Signed-off-by: Ivan Mal