Re: [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a policy

2018-05-11 Thread Andy Green
On 05/12/2018 12:03 AM, Ferruh Yigit wrote: On 5/11/2018 2:51 AM, Andy Green wrote: This is stopping the compiler telling you when you have done something stupid... that is something none of us can afford... Now gcc 8.x can tell you did something stupid despite trying to hide the evidence. R

Re: [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a policy

2018-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Friday, May 11, 2018 2:51 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a > policy > > This is stopping the compi

Re: [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a policy

2018-05-11 Thread Ferruh Yigit
On 5/11/2018 2:51 AM, Andy Green wrote: > This is stopping the compiler telling you when you have > done something stupid... that is something none of us > can afford... > > Now gcc 8.x can tell you did something stupid despite > trying to hide the evidence. > > Remove all the "black magic" casts

[dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a policy

2018-05-10 Thread Andy Green
This is stopping the compiler telling you when you have done something stupid... that is something none of us can afford... Now gcc 8.x can tell you did something stupid despite trying to hide the evidence. Remove all the "black magic" casts. Fix the actual problems. --- drivers/net/bnx2x/elink