Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2019-03-21 Thread Ferruh Yigit
On 3/20/2019 3:57 PM, Andrew Rybchenko wrote: > On 3/20/19 5:48 PM, Thomas Monjalon wrote: >> 19/03/2019 14:32, Yigit, Ferruh: >>> On 1/8/2019 11:30 AM, Tom Barbette wrote: Ferruh Yigit wrote: > Why timestamp offloading become useless? When timestamp offloading > enabled, > device

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2019-03-20 Thread Andrew Rybchenko
On 3/20/19 5:48 PM, Thomas Monjalon wrote: 19/03/2019 14:32, Yigit, Ferruh: On 1/8/2019 11:30 AM, Tom Barbette wrote: Ferruh Yigit wrote: Why timestamp offloading become useless? When timestamp offloading enabled, device fills 'mbuf.timestamp' and you can use it. But the frequency is unknown,

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2019-03-20 Thread Thomas Monjalon
19/03/2019 14:32, Yigit, Ferruh: > On 1/8/2019 11:30 AM, Tom Barbette wrote: > > Ferruh Yigit wrote: > >> Why timestamp offloading become useless? When timestamp offloading enabled, > >> device fills 'mbuf.timestamp' and you can use it. > > But the frequency is unknown, and the reference time neith

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2019-03-19 Thread Yigit, Ferruh
On 1/8/2019 11:30 AM, Tom Barbette wrote: > Ferruh Yigit wrote: >> Why timestamp offloading become useless? When timestamp offloading enabled, >> device fills 'mbuf.timestamp' and you can use it. > But the frequency is unknown, and the reference time neither. So it can be > used only to know that

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2019-01-08 Thread Tom Barbette
Ferruh Yigit wrote: > Why timestamp offloading become useless? When timestamp offloading enabled, > device fills 'mbuf.timestamp' and you can use it. But the frequency is unknown, and the reference time neither. So it can be used only to know that "some time passed" between packets. > For your ca

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2019-01-02 Thread Ferruh Yigit
On 12/23/2018 6:06 AM, Shahaf Shuler wrote: > Ferruh, > > I share the same thoughts as Tom here. > >   > >>Ferruh Yigit wrote : > >>> Is this a common enough feature to include into ethdev abstraction layer? >>> Or a > >>> feature for a single vendor? > >>  > >>I found reference to mbuf’s t

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2018-12-22 Thread Shahaf Shuler
Ferruh, I share the same thoughts as Tom here. >Ferruh Yigit wrote : >> Is this a common enough feature to include into ethdev abstraction layer? Or >> a >> feature for a single vendor? > >I found reference to mbuf’s timestamp field only in MLX5. I think it is the >only one to support timestamp

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2018-12-21 Thread Tom Barbette
Ferruh Yigit wrote : > Is this a common enough feature to include into ethdev abstraction layer? Or a > feature for a single vendor? I found reference to mbuf’s timestamp field only in MLX5. I think it is the only one to support timestamp offloading. This new API is only useful to make sense out

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2018-12-20 Thread Ferruh Yigit
On 12/19/2018 1:49 PM, Tom Barbette wrote: > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice. > + * > + * Read the current clock counter of an Ethernet device > + * > + * This returns the current raw clock value of an Ethernet device. > + * The value returned her

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2018-12-19 Thread Shahaf Shuler
Wednesday, December 19, 2018 3:50 PM, Tom Barbette: > Subject: [PATCH 1/3] rte_ethdev: Add API function to read dev clock > > Add rte_eth_read_clock to read the raw clock of a devide. > > The main use is to get the device clock conversion co-efficients to be able to > translate the raw clock of t

[dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2018-12-19 Thread Tom Barbette
Add rte_eth_read_clock to read the raw clock of a devide. The main use is to get the device clock conversion co-efficients to be able to translate the raw clock of the timestamp field of the pkt mbuf to a local synced time value. This function was missing to allow users to convert the RX timestam