[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-16 Thread Thomas Monjalon
2015-06-16 01:15, Zhang, Helin: > Yes, your patches are OK for me. I have acked it. Series applied, thanks

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-16 Thread Zhang, Helin
Hi Jay From: Jay Rolette [mailto:role...@infiniteio.com] Sent: Monday, June 15, 2015 8:43 PM To: Zhang, Helin Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/3] kni: minor opto On Sun, Jun 14, 2015 at 9:07 PM, Zhang, Helin mailto:helin.zhang at intel.com>> wrote: Would it be bet

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-16 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jay Rolette > Sent: Thursday, June 4, 2015 3:08 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/3] kni: minor opto > > Don't need the 'safe' version of list_for

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-15 Thread Jay Rolette
rmance improvement doesn't really matter. > > - Helin > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jay Rolette > > Sent: Thursday, June 4, 2015 3:19 AM > > To: dev at dpdk.org > > Subject: [dpdk-dev

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-15 Thread Zhang, Helin
Would it be better to modify the similar thing in kni_ioctl_create()? - Helin > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jay Rolette > Sent: Thursday, June 4, 2015 3:19 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/3]

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-04 Thread Thomas Monjalon
2015-06-04 14:40, Bruce Richardson: > On Thu, Jun 04, 2015 at 02:39:17PM +0100, Bruce Richardson wrote: > > On Wed, Jun 03, 2015 at 02:18:55PM -0500, Jay Rolette wrote: > > > Don't need the 'safe' version of list_for_each_entry() if you aren't > > > deleting from the list as you iterate over it >

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-04 Thread Bruce Richardson
On Thu, Jun 04, 2015 at 05:02:06PM +0200, Thomas Monjalon wrote: > 2015-06-04 14:40, Bruce Richardson: > > On Thu, Jun 04, 2015 at 02:39:17PM +0100, Bruce Richardson wrote: > > > On Wed, Jun 03, 2015 at 02:18:55PM -0500, Jay Rolette wrote: > > > > Don't need the 'safe' version of list_for_each_entr

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-04 Thread Bruce Richardson
On Thu, Jun 04, 2015 at 02:39:17PM +0100, Bruce Richardson wrote: > On Wed, Jun 03, 2015 at 02:18:55PM -0500, Jay Rolette wrote: > > Don't need the 'safe' version of list_for_each_entry() if you aren't > > deleting from the list as you iterate over it > > > > Signed-off-by: Jay Rolette > > Acke

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-04 Thread Bruce Richardson
On Wed, Jun 03, 2015 at 02:18:55PM -0500, Jay Rolette wrote: > Don't need the 'safe' version of list_for_each_entry() if you aren't deleting > from the list as you iterate over it > > Signed-off-by: Jay Rolette Acked-by: Bruce Richardson

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-03 Thread Jay Rolette
Don't need the 'safe' version of list_for_each_entry() if you aren't deleting from the list as you iterate over it Signed-off-by: Jay Rolette --- lib/librte_eal/linuxapp/kni/kni_misc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-03 Thread Jay Rolette
Don't need the 'safe' version of list_for_each_entry() if you aren't deleting from the list as you iterate over it Signed-off-by: Jay Rolette --- lib/librte_eal/linuxapp/kni/kni_misc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.