Re: [dpdk-dev] [PATCH 1/3] bitrate: change reg implementation to match API description

2021-10-01 Thread Thomas Monjalon
22/07/2021 22:24, Kevin Traynor: > On 22/07/2021 20:46, Thomas Monjalon wrote: > > 09/07/2021 17:19, Kevin Traynor: > >> rte_stats_bitrate_reg() API states it returns 'Zero on success'. > >> > >> However, the implementation directly returns the return of > >> rte_metrics_reg_names() which may be ze

Re: [dpdk-dev] [PATCH 1/3] bitrate: change reg implementation to match API description

2021-07-22 Thread Kevin Traynor
On 22/07/2021 20:46, Thomas Monjalon wrote: > 09/07/2021 17:19, Kevin Traynor: >> rte_stats_bitrate_reg() API states it returns 'Zero on success'. >> >> However, the implementation directly returns the return of >> rte_metrics_reg_names() which may be zero or positive on success, >> with a positive

Re: [dpdk-dev] [PATCH 1/3] bitrate: change reg implementation to match API description

2021-07-22 Thread Thomas Monjalon
09/07/2021 17:19, Kevin Traynor: > rte_stats_bitrate_reg() API states it returns 'Zero on success'. > > However, the implementation directly returns the return of > rte_metrics_reg_names() which may be zero or positive on success, > with a positive value also indicating the index. > > The user of

[dpdk-dev] [PATCH 1/3] bitrate: change reg implementation to match API description

2021-07-09 Thread Kevin Traynor
rte_stats_bitrate_reg() API states it returns 'Zero on success'. However, the implementation directly returns the return of rte_metrics_reg_names() which may be zero or positive on success, with a positive value also indicating the index. The user of rte_stats_bitrate_reg() should not care about