[dpdk-dev] [PATCH 1/2] vhost: enable any layout feature

2016-10-10 Thread Yuanhan Liu
On Mon, Oct 10, 2016 at 06:04:32AM +0300, Michael S. Tsirkin wrote: > > > So I guess at this point, we can teach vhost-user in qemu > > > that version 1 implies any_layout but only for machine types > > > qemu 2.8 and up. It sets a bad precedent but oh well. > > > > It should work. > > > > --

[dpdk-dev] [PATCH 1/2] vhost: enable any layout feature

2016-10-10 Thread Yuanhan Liu
On Mon, Oct 10, 2016 at 02:20:22AM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 28, 2016 at 10:28:48AM +0800, Yuanhan Liu wrote: > > On Tue, Sep 27, 2016 at 10:56:40PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Sep 27, 2016 at 11:11:58AM +0800, Yuanhan Liu wrote: > > > > On Mon, Sep 26, 2016

[dpdk-dev] [PATCH 1/2] vhost: enable any layout feature

2016-10-10 Thread Michael S. Tsirkin
On Mon, Oct 10, 2016 at 11:03:33AM +0800, Yuanhan Liu wrote: > On Mon, Oct 10, 2016 at 02:20:22AM +0300, Michael S. Tsirkin wrote: > > On Wed, Sep 28, 2016 at 10:28:48AM +0800, Yuanhan Liu wrote: > > > On Tue, Sep 27, 2016 at 10:56:40PM +0300, Michael S. Tsirkin wrote: > > > > On Tue, Sep 27, 2016

[dpdk-dev] [PATCH 1/2] vhost: enable any layout feature

2016-10-10 Thread Michael S. Tsirkin
On Wed, Sep 28, 2016 at 10:28:48AM +0800, Yuanhan Liu wrote: > On Tue, Sep 27, 2016 at 10:56:40PM +0300, Michael S. Tsirkin wrote: > > On Tue, Sep 27, 2016 at 11:11:58AM +0800, Yuanhan Liu wrote: > > > On Mon, Sep 26, 2016 at 10:24:55PM +0300, Michael S. Tsirkin wrote: > > > > On Mon, Sep 26, 2016

[dpdk-dev] [PATCH 1/2] vhost: enable any layout feature

2016-09-28 Thread Yuanhan Liu
On Tue, Sep 27, 2016 at 10:56:40PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 27, 2016 at 11:11:58AM +0800, Yuanhan Liu wrote: > > On Mon, Sep 26, 2016 at 10:24:55PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 26, 2016 at 11:01:58AM -0700, Stephen Hemminger wrote: > > > > I assume that i

[dpdk-dev] [PATCH 1/2] vhost: enable any layout feature

2016-09-27 Thread Michael S. Tsirkin
On Tue, Sep 27, 2016 at 11:11:58AM +0800, Yuanhan Liu wrote: > On Mon, Sep 26, 2016 at 10:24:55PM +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 26, 2016 at 11:01:58AM -0700, Stephen Hemminger wrote: > > > I assume that if using Version 1 that the bit will be ignored > > Yes, but I will just quo

[dpdk-dev] [PATCH 1/2] vhost: enable any layout feature

2016-09-27 Thread Stephen Hemminger
On Tue, 27 Sep 2016 11:11:58 +0800 Yuanhan Liu wrote: > On Mon, Sep 26, 2016 at 10:24:55PM +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 26, 2016 at 11:01:58AM -0700, Stephen Hemminger wrote: > > > I assume that if using Version 1 that the bit will be ignored > > Yes, but I will just quot

[dpdk-dev] [PATCH 1/2] vhost: enable any layout feature

2016-09-27 Thread Yuanhan Liu
On Mon, Sep 26, 2016 at 10:24:55PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 26, 2016 at 11:01:58AM -0700, Stephen Hemminger wrote: > > I assume that if using Version 1 that the bit will be ignored Yes, but I will just quote what you just said: what if the guest virtio device is a legacy devi

[dpdk-dev] [PATCH 1/2] vhost: enable any layout feature

2016-09-26 Thread Michael S. Tsirkin
On Mon, Sep 26, 2016 at 11:01:58AM -0700, Stephen Hemminger wrote: > I assume that if using Version 1 that the bit will be ignored > Therein lies a problem. If dpdk tweaks flags, updating it will break guest migration. One way is to require that users specify all flags fully when creating the vi

[dpdk-dev] [PATCH 1/2] vhost: enable any layout feature

2016-09-26 Thread Yuanhan Liu
The VIRTIO_F_ANY_LAYOUT feature allows virtio-net header and packet data in single vring desc if possible. Before that, it is assumed they will always take two descs. DPDK vhost removes this assumption since commit bc7f87a2c19f ("vhost: refactor dequeueing"), meaning we actually support this featu

[dpdk-dev] [PATCH 1/2] vhost: enable any layout feature

2016-09-26 Thread Stephen Hemminger
I assume that if using Version 1 that the bit will be ignored