Re: [dpdk-dev] [PATCH 1/2] power: switching to unbuffered stdio for /sys file access

2017-10-18 Thread Radoslaw Biernacki
Hi David, Thank you for comments. On 18 October 2017 at 12:33, Hunt, David wrote: > Hi Radoslaw, > > > On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: > >> This patch fixes the bug caused by improper use of buffered >> stdio file access for switching the CPU frequency and >> governor. Each wri

Re: [dpdk-dev] [PATCH 1/2] power: switching to unbuffered stdio for /sys file access

2017-10-18 Thread Hunt, David
Hi Radoslaw, On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: This patch fixes the bug caused by improper use of buffered stdio file access for switching the CPU frequency and governor. Each write operation when using buffered stdio must be flushed out and the return code from fflush() must be

Re: [dpdk-dev] [PATCH 1/2] power: switching to unbuffered stdio for /sys file access

2017-10-18 Thread Hunt, David
Hi Radoslaw, Thanks for the patch. Some comments below. On 16/10/2017 2:47 PM, Radoslaw Biernacki wrote: This patch fixes the bug caused by improper use of buffered stdio file access for switching the CPU frequency and governor. Each write operation when using buffered stdio must be flushed ou

[dpdk-dev] [PATCH 1/2] power: switching to unbuffered stdio for /sys file access

2017-10-16 Thread Radoslaw Biernacki
This patch fixes the bug caused by improper use of buffered stdio file access for switching the CPU frequency and governor. Each write operation when using buffered stdio must be flushed out and the return code from fflush() must be verified. In buffered mode, write() syscall return value is is not