Re: [dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-05-03 Thread Jan Viktorin
On Fri, 28 Apr 2017 10:19:20 + "Sekhar, Ashwin" wrote: > Hi Jan, > Thanks for the comments. Please see my responses inline. > > On Friday 28 April 2017 03:25 PM, Jan Viktorin wrote: > > Hello Ashwin Sekhar, > > > > some comments below... > > [...] > >> > >> #include > >> +#include > >>

Re: [dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-04-28 Thread Sekhar, Ashwin
Hi Jan, Thanks for the comments. Please see my responses inline. On Friday 28 April 2017 03:25 PM, Jan Viktorin wrote: > Hello Ashwin Sekhar, > > some comments below... > > On Thu, 27 Apr 2017 07:10:20 -0700 > Ashwin Sekhar T K wrote: > >> * Added CRC compute APIs for arm64 utilizing the pmull ca

Re: [dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-04-28 Thread Jan Viktorin
Hello Ashwin Sekhar, some comments below... On Thu, 27 Apr 2017 07:10:20 -0700 Ashwin Sekhar T K wrote: > * Added CRC compute APIs for arm64 utilizing the pmull capability > * Added new file net_crc_neon.h to hold the arm64 pmull CRC > implementation > * Added crypto capability in compilation

[dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-04-27 Thread Ashwin Sekhar T K
* Added CRC compute APIs for arm64 utilizing the pmull capability * Added new file net_crc_neon.h to hold the arm64 pmull CRC implementation * Added crypto capability in compilation of generic armv8 and thunderx targets * pmull CRC version is used only after checking the pmull capability at r

[dpdk-dev] [PATCH 1/2] net: add arm64 neon version of CRC compute APIs

2017-04-27 Thread Ashwin Sekhar T K
* Added CRC compute APIs for arm64 utilizing the pmull capability * Added new file net_crc_neon.h to hold the arm64 pmull CRC implementation * Added crypto capability in compilation of generic armv8 and thunderx targets * pmull CRC version is used only after checking the pmull capability at r