Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-19 Thread Nélio Laranjeiro
On Fri, Jan 19, 2018 at 02:30:45PM +0100, Olivier Matz wrote: > On Fri, Jan 19, 2018 at 09:43:14AM +0100, Olivier Matz wrote: > > On Fri, Jan 19, 2018 at 09:35:01AM +0100, Nélio Laranjeiro wrote: > > > On Thu, Jan 18, 2018 at 05:13:08PM +0100, Olivier Matz wrote: > > > > On Thu, Jan 18, 2018 at 05:

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-19 Thread Nélio Laranjeiro
On Fri, Jan 19, 2018 at 02:30:45PM +0100, Olivier Matz wrote: > On Fri, Jan 19, 2018 at 09:43:14AM +0100, Olivier Matz wrote: > > On Fri, Jan 19, 2018 at 09:35:01AM +0100, Nélio Laranjeiro wrote: > > > On Thu, Jan 18, 2018 at 05:13:08PM +0100, Olivier Matz wrote: > > > > On Thu, Jan 18, 2018 at 05:

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-19 Thread Olivier Matz
On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote: > On error, mlx5_dev_start() does not return a negative value > as it is supposed to do. The consequence is that the application > (ex: testpmd) does not notice that the port is not started > and begins the rxtx on an uninitialized port,

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-19 Thread Olivier Matz
On Fri, Jan 19, 2018 at 09:43:14AM +0100, Olivier Matz wrote: > On Fri, Jan 19, 2018 at 09:35:01AM +0100, Nélio Laranjeiro wrote: > > On Thu, Jan 18, 2018 at 05:13:08PM +0100, Olivier Matz wrote: > > > On Thu, Jan 18, 2018 at 05:04:27PM +0100, Nélio Laranjeiro wrote: > > > > On Thu, Jan 18, 2018 at

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-19 Thread Olivier Matz
On Fri, Jan 19, 2018 at 09:35:01AM +0100, Nélio Laranjeiro wrote: > On Thu, Jan 18, 2018 at 05:13:08PM +0100, Olivier Matz wrote: > > On Thu, Jan 18, 2018 at 05:04:27PM +0100, Nélio Laranjeiro wrote: > > > On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote: > > > > On error, mlx5_dev_star

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-19 Thread Nélio Laranjeiro
On Thu, Jan 18, 2018 at 05:13:08PM +0100, Olivier Matz wrote: > On Thu, Jan 18, 2018 at 05:04:27PM +0100, Nélio Laranjeiro wrote: > > On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote: > > > On error, mlx5_dev_start() does not return a negative value > > > as it is supposed to do. The co

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-18 Thread Yongseok Koh
> On Jan 18, 2018, at 8:13 AM, Olivier Matz wrote: > > On Thu, Jan 18, 2018 at 05:04:27PM +0100, Nélio Laranjeiro wrote: >> On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote: >>> On error, mlx5_dev_start() does not return a negative value >>> as it is supposed to do. The consequence is

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-18 Thread Olivier Matz
On Thu, Jan 18, 2018 at 05:04:27PM +0100, Nélio Laranjeiro wrote: > On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote: > > On error, mlx5_dev_start() does not return a negative value > > as it is supposed to do. The consequence is that the application > > (ex: testpmd) does not notice th

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-18 Thread Nélio Laranjeiro
On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote: > On error, mlx5_dev_start() does not return a negative value > as it is supposed to do. The consequence is that the application > (ex: testpmd) does not notice that the port is not started > and begins the rxtx on an uninitialized port,

[dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-18 Thread Olivier Matz
On error, mlx5_dev_start() does not return a negative value as it is supposed to do. The consequence is that the application (ex: testpmd) does not notice that the port is not started and begins the rxtx on an uninitialized port, which crashes. Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts man